Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1168393007: remove crypto_unittests_run's uneeded xdisplaycheck dep (Closed)

Created:
5 years, 6 months ago by Mostyn Bramley-Moore
Modified:
5 years, 6 months ago
Reviewers:
M-A Ruel, Ryan Sleevi
CC:
chromium-reviews, M-A Ruel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove crypto_unittests_run's uneeded xdisplaycheck dep The crypto_unittests_run target has an incomplete and unnecessary dependency on xdisplaycheck- let's remove this dependency. Committed: https://crrev.com/360543640c8e73c0fb4952f6000b895dc69f1cc2 Cr-Commit-Position: refs/heads/master@{#333546}

Patch Set 1 #

Patch Set 2 : remove crypto_unittests_run's xdisplaycheck dep completely #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -37 lines) Patch
M crypto/crypto_unittests.isolate View 1 1 chunk +11 lines, -37 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Mostyn Bramley-Moore
@Ryan: something like this seems to be required for crypto_unittests_run to succeed. Without this, I ...
5 years, 6 months ago (2015-06-09 15:18:44 UTC) #2
M-A Ruel
Actually, I wonder if xvfb is needed at all to succeed. Can someone run this ...
5 years, 6 months ago (2015-06-09 15:20:22 UTC) #4
Mostyn Bramley-Moore
On 2015/06/09 15:20:22, M-A Ruel wrote: > Actually, I wonder if xvfb is needed at ...
5 years, 6 months ago (2015-06-09 15:25:46 UTC) #5
M-A Ruel
Great! lgtm
5 years, 6 months ago (2015-06-09 16:56:13 UTC) #6
Ryan Sleevi
lgtm
5 years, 6 months ago (2015-06-09 18:01:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168393007/20001
5 years, 6 months ago (2015-06-09 18:01:41 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-09 19:17:32 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 19:18:24 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/360543640c8e73c0fb4952f6000b895dc69f1cc2
Cr-Commit-Position: refs/heads/master@{#333546}

Powered by Google App Engine
This is Rietveld 408576698