Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1168393002: Service Worker: Add ServiceWorkerContainer.getRegistrations() method. (Blink layout tests) (Closed)

Created:
5 years, 6 months ago by jungkees
Modified:
5 years, 6 months ago
Reviewers:
falken, kinuko, xiang, nhiroki, tkent
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Service Worker: Add ServiceWorkerContainer.getRegistrations() method. (Blink layout tests) Implement ServiceWorkerContainer.getReistrations() method as per spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#navigator-service-worker-getRegistrations Companion CL (Blink): https://codereview.chromium.org/1165363003/ Companion CL (Chromium): https://codereview.chromium.org/1146913004/ Companion CL (Previous review): https://codereview.chromium.org/1143293003/ BUG=478382 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197023

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Add a test for checking the method returns only same origin registrations. #

Patch Set 4 : Add a missing unregister call in getregistrations.html. #

Total comments: 7

Patch Set 5 : Remove iframe at the end of the test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -4 lines) Patch
M LayoutTests/http/tests/serviceworker/claim-not-using-registration.html View 2 chunks +5 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch-event-after-navigation-within-page.html View 2 chunks +2 lines, -2 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/getregistrations.html View 1 2 3 4 1 chunk +130 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/resources/frame-for-getregistrations.html View 1 2 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
jungkees
I made this previous CL a 3-sided patch with the blink-side apart: https://codereview.chromium.org/1143293003/ PTAL
5 years, 6 months ago (2015-06-09 09:09:28 UTC) #2
falken
Looks pretty good, one more idea... Is it possible to add a test where you ...
5 years, 6 months ago (2015-06-10 03:50:24 UTC) #3
jungkees
Sure. I'll add a test about checking whether it gets the registrations only for the ...
5 years, 6 months ago (2015-06-10 04:53:54 UTC) #4
jungkees
A new snapshot has been uploaded having addressed the comments and added a test to ...
5 years, 6 months ago (2015-06-11 12:43:41 UTC) #6
jungkees
Added a missing unregister call in getregistrations.html.
5 years, 6 months ago (2015-06-11 15:02:54 UTC) #7
falken
lgtm nice tests! https://codereview.chromium.org/1168393002/diff/80001/LayoutTests/http/tests/serviceworker/fetch-event-after-navigation-within-page.html File LayoutTests/http/tests/serviceworker/fetch-event-after-navigation-within-page.html (right): https://codereview.chromium.org/1168393002/diff/80001/LayoutTests/http/tests/serviceworker/fetch-event-after-navigation-within-page.html#newcode44 LayoutTests/http/tests/serviceworker/fetch-event-after-navigation-within-page.html:44: return service_worker_unregister_and_register(t, worker, scope) good catches ...
5 years, 6 months ago (2015-06-12 06:16:37 UTC) #8
jungkees
Comments addressed. Thanks for review! https://codereview.chromium.org/1168393002/diff/80001/LayoutTests/http/tests/serviceworker/getregistrations.html File LayoutTests/http/tests/serviceworker/getregistrations.html (right): https://codereview.chromium.org/1168393002/diff/80001/LayoutTests/http/tests/serviceworker/getregistrations.html#newcode29 LayoutTests/http/tests/serviceworker/getregistrations.html:29: assert_array_equals( It should guarantee ...
5 years, 6 months ago (2015-06-12 07:37:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168393002/100001
5 years, 6 months ago (2015-06-12 07:37:54 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 09:19:07 UTC) #13
Message was sent while issue was closed. 
Committed patchset #5 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197023

Powered by Google App Engine
This is Rietveld 408576698