chrome/common/extensions/api/extension_action/action_info.cc - Issue 1168383002: Implement sidebar support for extension action popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/action_info.cc

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add sidebar handling logic and browser_tests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/api/extension_action/action_info.cc

diff --git a/chrome/common/extensions/api/extension_action/action_info.cc b/chrome/common/extensions/api/extension_action/action_info.cc

index 8cf0386d3613ed37f4524ca95cfa98975ac805c4..4283c5d1c4703b3b35f358d7c8a12c64687641a7 100644

--- a/chrome/common/extensions/api/extension_action/action_info.cc

+++ b/chrome/common/extensions/api/extension_action/action_info.cc

@@ -182,6 +182,11 @@ scoped_ptr<ActionInfo> ActionInfo::Load(const Extension* extension,

}

+ // Should open popup in sidebar?

+ if (!dict->GetBoolean(keys::kPageActionOpenInSidebar,

+ &result->open_in_sidebar))

+ result->open_in_sidebar = false;

return result.Pass();

}