extensions/common/manifest_constants.cc - Issue 1168383002: Implement sidebar support for extension action popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_constants.cc

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix assertion failure at extension_view_host.cc Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/manifest_constants.cc

diff --git a/extensions/common/manifest_constants.cc b/extensions/common/manifest_constants.cc

index 6dd9a4126bda0f822cbbdbedbcdf3b0a034ea631..7863b6d64f5703f4e2665259810b93d9b82cc85b 100644

--- a/extensions/common/manifest_constants.cc

+++ b/extensions/common/manifest_constants.cc

@@ -114,6 +114,7 @@ const char kPageActionDefaultPopup[] = "default_popup";

const char kPageActionDefaultTitle[] = "default_title";

const char kPageActionIcons[] = "icons";

const char kPageActionId[] = "id";

+const char kPageActionOpenInSidebar[] = "open_in_sidebar";

const char kPageActionPopup[] = "popup";

const char kPageActionPopupPath[] = "path";

const char kPermissions[] = "permissions";

« no previous file with comments | « extensions/common/manifest_constants.h ('k') | extensions/common/view_type.h » ('j') | no next file with comments »