extensions/browser/extension_host.cc - Issue 1168383002: Implement sidebar support for extension action popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_host.cc

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix assertion failure at extension_view_host.cc Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/extension_host.cc

diff --git a/extensions/browser/extension_host.cc b/extensions/browser/extension_host.cc

index df7b74d754d6df61fb5ed111b2bb64b6f7140bee..81acc76cefced4b3382f96fffe2aef42d1be1891 100644

--- a/extensions/browser/extension_host.cc

+++ b/extensions/browser/extension_host.cc

@@ -68,9 +68,10 @@ ExtensionHost::ExtensionHost(const Extension* extension,

// Not used for panels, see PanelHost.

DCHECK(host_type == VIEW_TYPE_EXTENSION_BACKGROUND_PAGE ||

host_type == VIEW_TYPE_EXTENSION_DIALOG ||

- host_type == VIEW_TYPE_EXTENSION_POPUP);

+ host_type == VIEW_TYPE_EXTENSION_POPUP ||

+ host_type == VIEW_TYPE_EXTENSION_SIDEBAR);

host_contents_.reset(WebContents::Create(

- WebContents::CreateParams(browser_context_, site_instance))),

+ WebContents::CreateParams(browser_context_, site_instance)));

content::WebContentsObserver::Observe(host_contents_.get());

host_contents_->SetDelegate(this);

SetViewType(host_contents_.get(), host_type);