Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4441)

Unified Diff: chrome/common/extensions/api/extension_action/action_info.cc

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix assertion failure at extension_view_host.cc Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_action/action_info.cc
diff --git a/chrome/common/extensions/api/extension_action/action_info.cc b/chrome/common/extensions/api/extension_action/action_info.cc
index 8cf0386d3613ed37f4524ca95cfa98975ac805c4..5892fdcdc06f3580f1319ca86d44df052fa250fb 100644
--- a/chrome/common/extensions/api/extension_action/action_info.cc
+++ b/chrome/common/extensions/api/extension_action/action_info.cc
@@ -45,8 +45,7 @@ static const ActionInfo* GetActionInfo(const Extension* extension,
} // namespace
-ActionInfo::ActionInfo() {
-}
+ActionInfo::ActionInfo() : open_in_sidebar(false) {}
ActionInfo::~ActionInfo() {
}
@@ -182,6 +181,9 @@ scoped_ptr<ActionInfo> ActionInfo::Load(const Extension* extension,
}
}
+ // Should open popup in sidebar?
+ dict->GetBoolean(keys::kPageActionOpenInSidebar, &result->open_in_sidebar);
+
return result.Pass();
}
« no previous file with comments | « chrome/common/extensions/api/extension_action/action_info.h ('k') | chrome/test/data/extensions/sidebar/manifest.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698