chrome/browser/ui/toolbar/toolbar_action_view_controller.h - Issue 1168383002: Implement sidebar support for extension action popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/toolbar_action_view_controller.h

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix assertion failure at extension_view_host.cc Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/toolbar_action_view_controller.h

diff --git a/chrome/browser/ui/toolbar/toolbar_action_view_controller.h b/chrome/browser/ui/toolbar/toolbar_action_view_controller.h

index 4702922bec0ece90459b5591814ac8f7e3dffa0c..063d431f83f554af7feabaacbd06f1dee38765a1 100644

--- a/chrome/browser/ui/toolbar/toolbar_action_view_controller.h

+++ b/chrome/browser/ui/toolbar/toolbar_action_view_controller.h

@@ -65,6 +65,9 @@ class ToolbarActionViewController {

// Hides the current popup, if one is visible.

virtual void HidePopup() = 0;

+ // Hides the current sidebar, if one is visible.

+ virtual void HideSidebar() {}

// Returns the native view for the popup, if one is active.

virtual gfx::NativeView GetPopupNativeView() = 0;