Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5041)

Unified Diff: chrome/browser/extensions/sidebar_container.cc

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/sidebar_container.cc
diff --git a/chrome/browser/extensions/sidebar_container.cc b/chrome/browser/extensions/sidebar_container.cc
new file mode 100644
index 0000000000000000000000000000000000000000..0c91fc4319e5be6005ac3a7194363c915f3d756d
--- /dev/null
+++ b/chrome/browser/extensions/sidebar_container.cc
@@ -0,0 +1,53 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
Devlin 2015/07/30 17:56:46 Umm... this class doesn't do anything other than i
ltilve 2015/08/07 16:15:02 Done. We have refactored out sidebarContainer now.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/sidebar_container.h"
+
+#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_view_host_factory.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "content/public/browser/notification_details.h"
+#include "content/public/browser/notification_source.h"
+#include "content/public/browser/web_contents.h"
+#include "url/gurl.h"
+
+namespace extensions {
+SidebarContainer::SidebarContainer(Browser* browser,
+ content::WebContents* tab,
+ const GURL& url)
+ : host_(extensions::ExtensionViewHostFactory::CreateSidebarHost(url,
+ browser)),
+ tab_(tab),
+ browser_(browser),
+ tab_strip_model_observer_(this) {
+ // Listen for the containing view calling window.close();
+ registrar_.Add(
+ this, extensions::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE,
+ content::Source<content::BrowserContext>(host_->browser_context()));
+
+ host_->CreateRenderViewSoon();
+ sidebar_contents()->SetInitialFocus();
+
+ tab_strip_model_observer_.Add(browser_->tab_strip_model());
+}
+
+SidebarContainer::~SidebarContainer() {
+ tab_strip_model_observer_.Remove(browser_->tab_strip_model());
+}
+
+void SidebarContainer::TabClosingAt(TabStripModel* tab_strip_model,
+ content::WebContents* contents,
+ int index) {
+}
+
+void SidebarContainer::Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) {
+ DCHECK_EQ(type, extensions::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE)
+ << "Received unexpected notification";
+}
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698