Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/browser/extension_host.cc

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/extensions/extension_action_view_controller.cc ('K') | « chrome/test/data/sidebar/simple_page.html ('k') | extensions/browser/extension_system.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_host.cc
diff --git a/extensions/browser/extension_host.cc b/extensions/browser/extension_host.cc
index 124a8fd2ddf3c4ca1502ec2369beb1676c774073..8ca0ea167a361e71e10c56097389a1dc06ceac63 100644
--- a/extensions/browser/extension_host.cc
+++ b/extensions/browser/extension_host.cc
@@ -67,9 +67,10 @@ ExtensionHost::ExtensionHost(const Extension* extension,
// Not used for panels, see PanelHost.
DCHECK(host_type == VIEW_TYPE_EXTENSION_BACKGROUND_PAGE ||
host_type == VIEW_TYPE_EXTENSION_DIALOG ||
- host_type == VIEW_TYPE_EXTENSION_POPUP);
+ host_type == VIEW_TYPE_EXTENSION_POPUP ||
+ host_type == VIEW_TYPE_EXTENSION_SIDEBAR);
host_contents_.reset(WebContents::Create(
- WebContents::CreateParams(browser_context_, site_instance))),
+ WebContents::CreateParams(browser_context_, site_instance)));
content::WebContentsObserver::Observe(host_contents_.get());
host_contents_->SetDelegate(this);
SetViewType(host_contents_.get(), host_type);
« chrome/browser/ui/extensions/extension_action_view_controller.cc ('K') | « chrome/test/data/sidebar/simple_page.html ('k') | extensions/browser/extension_system.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698