chrome/common/extensions/api/extension_action/action_info.h - Issue 1168383002: Implement sidebar support for extension action popups

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/api/extension_action/action_info.h

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/extensions/extension_action_view_controller.cc ('K') | « chrome/common/extensions/api/developer_private.idl ('k') | chrome/common/extensions/api/extension_action/action_info.cc » ('j') | chrome/common/extensions/api/extension_action/action_info.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_ACTION_INFO_H_	5 #ifndef CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_ACTION_INFO_H_

6 #define CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_ACTION_INFO_H_	6 #define CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_ACTION_INFO_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "base/strings/string16.h"	10 #include "base/strings/string16.h"

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
58 // Returns true if the extension needs a verbose install message because	58 // Returns true if the extension needs a verbose install message because

59 // of its page action.	59 // of its page action.

60 static bool IsVerboseInstallMessage(const Extension* extension);	60 static bool IsVerboseInstallMessage(const Extension* extension);

61	61

62 // Empty implies the key wasn't present.	62 // Empty implies the key wasn't present.

63 ExtensionIconSet default_icon;	63 ExtensionIconSet default_icon;

64 std::string default_title;	64 std::string default_title;

65 GURL default_popup_url;	65 GURL default_popup_url;

66 // action id -- only used with legacy page actions API.	66 // action id -- only used with legacy page actions API.

67 std::string id;	67 std::string id;

	68 bool open_in_sidebar;
	Devlin 2015/06/19 19:56:10 This should be initialized in the ctor This should be initialized in the ctor ltilve 2015/06/28 22:44:20 Done. Show quoted text On 2015/06/19 19:56:10, Devlin wrote: > This should be initialized in the ctor Done.
68 };	69 };

69	70

70 } // namespace extensions	71 } // namespace extensions

71	72

72 #endif // CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_ACTION_INFO_H_	73 #endif // CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_ACTION_INFO_H_

OLD	NEW