Implement sidebar support for extension action popups

chrome/common/extensions/api/extension_action/action_info.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/api/extension_action/action_info.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/common/extensions/api/commands/commands_handler.h"
 #include "extensions/common/constants.h"
@@ skipping 164 matching lines @@
         *error = ErrorUtils::FormatErrorMessageUTF16(
             errors::kInvalidPageActionPopupPath, url_str);
         return scoped_ptr<ActionInfo>();
       }
     } else {
       DCHECK(result->default_popup_url.is_empty())
           << "Shouldn't be possible for the popup to be set.";
     }
   }
 
+  // Should open popup in sidebar?
+  if (!dict->GetBoolean(keys::kPageActionOpenInSidebar,
+                        &result->open_in_sidebar))
+    result->open_in_sidebar = false;

[Devlin, 2015/06/19 19:56:10]

Once open_in_sidebar is initialized, this line won't be needed.

[ltilve, 2015/06/28 22:44:20]

Done.

+
   return result.Pass();
 }
 
 // static
 const ActionInfo* ActionInfo::GetBrowserActionInfo(const Extension* extension) {
   return GetActionInfo(extension, keys::kBrowserAction);
 }
 
 const ActionInfo* ActionInfo::GetPageActionInfo(const Extension* extension) {
   return GetActionInfo(extension, keys::kPageAction);
@@ skipping 25 matching lines @@
 
 // static
 bool ActionInfo::IsVerboseInstallMessage(const Extension* extension) {
   const ActionInfo* page_action_info = GetPageActionInfo(extension);
   return page_action_info &&
       (CommandsInfo::GetPageActionCommand(extension) ||
        !page_action_info->default_icon.empty());
 }
 
 }  // namespace extensions