Implement sidebar support for extension action popups

chrome/browser/extensions/sidebar_manager_observer.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_SIDEBAR_MANAGER_OBSERVER_H_
+#define CHROME_BROWSER_EXTENSIONS_SIDEBAR_MANAGER_OBSERVER_H_
+
+namespace content {
+class WebContents;
+};
+
+class SidebarManagerObserver {

[Devlin, 2015/06/19 19:56:10]

for good measure, add a virtual destructor.

[ltilve, 2015/06/28 22:44:20]

Done.

+ public:
+  // Called when sidebar is shown

[Devlin, 2015/06/19 19:56:10]

Add periods to these comments.

[ltilve, 2015/06/28 22:44:20]

Done.

+  virtual void OnSidebarShown(content::WebContents* tab,
+                              const std::string& content_id) {}
+
+  // Called when sidebar is hidden
+  virtual void OnSidebarHidden(content::WebContents* tab,
+                               const std::string& content_id) {}
+
+  // Called when sidebar changes

[Devlin, 2015/06/19 19:56:10]

"changes" is pretty vague.

[ltilve, 2015/06/28 22:44:20]

Done.

+  virtual void OnSidebarSwitched(content::WebContents* old_tab,

[Devlin, 2015/06/19 19:56:10]

This is observed in the ExtensionActionViewController, but doesn't seem to be
called from the Manager?

[ltilve, 2015/06/28 22:44:20]

It's called from the Manager at the SidebarManager::NotifyStateChanges function
that was moved to the UI patchset. I guess that then all SidebarSwitched code
should be moved there. Is it correct?

[ltilve, 2015/06/29 10:46:51]

Done. I've moved it to https://codereview.chromium.org/1169823005

+                                 const std::string& old_content_id,
+                                 content::WebContents* new_tab,
+                                 const std::string& new_content_id) {}
+};
+
+#endif  // CHROME_BROWSER_EXTENSIONS_SIDEBAR_MANAGER_OBSERVER_H_