Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: extensions/browser/process_manager.cc

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix assertion failure at extension_view_host.cc Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/browser/extension_host.cc ('k') | extensions/common/manifest_constants.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/process_manager.h" 5 #include "extensions/browser/process_manager.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 ExtensionRenderFrameData() 160 ExtensionRenderFrameData()
161 : view_type(VIEW_TYPE_INVALID), has_keepalive(false) {} 161 : view_type(VIEW_TYPE_INVALID), has_keepalive(false) {}
162 162
163 // Returns whether the view can keep the lazy background page alive or not. 163 // Returns whether the view can keep the lazy background page alive or not.
164 bool CanKeepalive() const { 164 bool CanKeepalive() const {
165 switch (view_type) { 165 switch (view_type) {
166 case VIEW_TYPE_APP_WINDOW: 166 case VIEW_TYPE_APP_WINDOW:
167 case VIEW_TYPE_BACKGROUND_CONTENTS: 167 case VIEW_TYPE_BACKGROUND_CONTENTS:
168 case VIEW_TYPE_EXTENSION_DIALOG: 168 case VIEW_TYPE_EXTENSION_DIALOG:
169 case VIEW_TYPE_EXTENSION_POPUP: 169 case VIEW_TYPE_EXTENSION_POPUP:
170 case VIEW_TYPE_EXTENSION_SIDEBAR:
170 case VIEW_TYPE_LAUNCHER_PAGE: 171 case VIEW_TYPE_LAUNCHER_PAGE:
171 case VIEW_TYPE_PANEL: 172 case VIEW_TYPE_PANEL:
172 case VIEW_TYPE_TAB_CONTENTS: 173 case VIEW_TYPE_TAB_CONTENTS:
173 case VIEW_TYPE_VIRTUAL_KEYBOARD: 174 case VIEW_TYPE_VIRTUAL_KEYBOARD:
174 return true; 175 return true;
175 176
176 case VIEW_TYPE_INVALID: 177 case VIEW_TYPE_INVALID:
177 case VIEW_TYPE_EXTENSION_BACKGROUND_PAGE: 178 case VIEW_TYPE_EXTENSION_BACKGROUND_PAGE:
178 return false; 179 return false;
179 } 180 }
(...skipping 778 matching lines...) Expand 10 before | Expand all | Expand 10 after
958 if (extension && !IncognitoInfo::IsSplitMode(extension)) { 959 if (extension && !IncognitoInfo::IsSplitMode(extension)) {
959 BrowserContext* original_context = 960 BrowserContext* original_context =
960 ExtensionsBrowserClient::Get()->GetOriginalContext(browser_context()); 961 ExtensionsBrowserClient::Get()->GetOriginalContext(browser_context());
961 return ProcessManager::Get(original_context)->GetSiteInstanceForURL(url); 962 return ProcessManager::Get(original_context)->GetSiteInstanceForURL(url);
962 } 963 }
963 964
964 return ProcessManager::GetSiteInstanceForURL(url); 965 return ProcessManager::GetSiteInstanceForURL(url);
965 } 966 }
966 967
967 } // namespace extensions 968 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/extension_host.cc ('k') | extensions/common/manifest_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698