Implement sidebar support for extension action popups

chrome/browser/extensions/sidebar_browsertest.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/files/file_path.h"
+#include "base/path_service.h"
+#include "chrome/browser/extensions/browser_action_test_util.h"
+#include "chrome/browser/extensions/extension_action_manager.h"
+#include "chrome/browser/extensions/extension_browsertest.h"
+#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_commands.h"
+#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/extensions/extension_action_view_controller.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/toolbar/toolbar_actions_bar.h"
+#include "chrome/common/chrome_paths.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "extensions/common/extension.h"
+
+using content::NavigationController;
+using content::WebContents;
+
+namespace extensions {
+
+class SidebarTest : public ExtensionBrowserTest {

[Devlin, 2015/07/30 17:56:46]

Why does this need to be a browser test?

[ltilve, 2015/08/07 16:15:02]

We have been earlier following the suggestion of testing opening and closing
sidebars through SidebarManager API with unittests. Now we don't have any more a
SidebarManager to be able to force creation of sidebars, and testing inside
unittests any popup/sidebar logic seems to be failing because at
ExtensionActionViewController::ExecuteAction the ExtensionAction::ACTION_NONE
type is returned due to null web_contents.

For those reasons we are thinking that we need it to be a browser test. Maybe we
are not properly setting anything for it, please let us know if we are wrong
about this.

+ public:
+  SidebarTest() {}
+  ~SidebarTest() override {}
+
+ protected:
+  // InProcessBrowserTest
+  void SetUpOnMainThread() override {
+    ExtensionBrowserTest::SetUpOnMainThread();
+
+    // Load test sidebar extension.
+    base::FilePath extension_path;
+    ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &extension_path));
+    extension_path = extension_path.AppendASCII("sidebar");
+    extension_ = LoadExtension(extension_path);
+
+    ASSERT_TRUE(extension_);
+
+    browser_action_test_util_.reset(new BrowserActionTestUtil(browser()));
+  }
+
+  ExtensionAction* GetBrowserAction(const Extension& extension) {
+    return ExtensionActionManager::Get(browser()->profile())
+        ->GetBrowserAction(extension);
+  }
+
+  void ClickExtensionBrowserAction() {
+    browser_action_test_util_.get()->Press(0);
+  }
+
+  void DisableOpenInSidebar() {
+    GetBrowserAction(*extension_)->set_open_in_sidebar(false);
+  }
+
+  ExtensionActionViewController* getExtensionActionViewController() {
+    return static_cast<ExtensionActionViewController*>(
+        browser_action_test_util_.get()
+            ->GetToolbarActionsBar()
+            ->GetActions()[0]);
+  }
+
+  bool HasSidebarForCurrentTab() {
+    return getExtensionActionViewController()->is_showing_sidebar();
+  }
+
+ private:
+  const Extension* extension_;
+  scoped_ptr<BrowserActionTestUtil> browser_action_test_util_;
+};
+
+// Tests that cliking on the browser action show/hides the sidebar
+IN_PROC_BROWSER_TEST_F(SidebarTest, CreateSidebar) {
+  EXPECT_FALSE(HasSidebarForCurrentTab());
+  ClickExtensionBrowserAction();
+  EXPECT_TRUE(HasSidebarForCurrentTab());
+  ClickExtensionBrowserAction();
+  EXPECT_FALSE(HasSidebarForCurrentTab());
+}
+
+// Tests that sidebar visible at the other tabs
+IN_PROC_BROWSER_TEST_F(SidebarTest, SwitchingTabs) {
+  // Open sidebar and move to a new tab
+  ClickExtensionBrowserAction();
+  AddTabAtIndex(0, GURL(url::kAboutBlankURL), ui::PAGE_TRANSITION_TYPED);
+  EXPECT_TRUE(HasSidebarForCurrentTab());
+
+  // Close sidebar and switch back to the first tab
+  ClickExtensionBrowserAction();
+  TabStripModel* tab_strip_model = browser()->tab_strip_model();
+  tab_strip_model->ActivateTabAt(0, false);
+  EXPECT_FALSE(HasSidebarForCurrentTab());
+}
+
+// Tests that sidebars are not shown if open_in_sidebar: false
+IN_PROC_BROWSER_TEST_F(SidebarTest, CreateDisabledSidebar) {

[Devlin, 2015/07/30 17:56:46]

What about testing multiple extensions with sidebars?

[ltilve, 2015/08/07 16:15:02]

Done.

+  DisableOpenInSidebar();
+  ClickExtensionBrowserAction();
+  EXPECT_FALSE(HasSidebarForCurrentTab());
+}
+
+}  // namespace extensions