Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1168333002: Gallery: use shadow dom with Polymer. (Closed)

Created:
5 years, 6 months ago by yawano
Modified:
5 years, 6 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: use shadow dom with Polymer. BUG=488227 TEST=none Committed: https://crrev.com/f17dc18bc3dd133d2be1c92d2f4e3c0b05d4d9b1 Cr-Commit-Position: refs/heads/master@{#333449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/file_manager/file_manager/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/gallery/gallery.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
yawano
PTAL. Thank you!
5 years, 6 months ago (2015-06-09 04:20:34 UTC) #2
fukino
lgtm
5 years, 6 months ago (2015-06-09 04:47:07 UTC) #3
yawano
On 2015/06/09 04:47:07, fukino wrote: > lgtm Thank you!
5 years, 6 months ago (2015-06-09 05:04:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168333002/1
5 years, 6 months ago (2015-06-09 05:05:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 05:11:36 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f17dc18bc3dd133d2be1c92d2f4e3c0b05d4d9b1 Cr-Commit-Position: refs/heads/master@{#333449}
5 years, 6 months ago (2015-06-09 05:13:15 UTC) #8
yawano
5 years, 6 months ago (2015-06-10 02:27:08 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1172533003/ by yawano@chromium.org.

The reason for reverting is: All of Gallery Material Redesign will happen in
M46..

Powered by Google App Engine
This is Rietveld 408576698