Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 116833004: Remove duplicate chromedriver2_unittests target. (Closed)

Created:
7 years ago by kkania
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove duplicate chromedriver2_unittests target. All infra has been updated to use chromedriver_unittests instead. BUG=298192 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254569

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -58 lines) Patch
M build/all.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +29 lines, -56 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
kkania
7 years ago (2013-12-18 22:46:28 UTC) #1
chrisgao (Use stgao instead)
lgtm
7 years ago (2013-12-19 00:25:19 UTC) #2
kkania
This needs to wait for other CLs and some master restarts before committing. See the ...
7 years ago (2013-12-19 01:08:29 UTC) #3
kkania
The CQ bit was checked by kkania@chromium.org
6 years, 9 months ago (2014-03-03 17:17:49 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 17:18:15 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-03-03 17:18:16 UTC) #6
stgao
lgtm
6 years, 9 months ago (2014-03-03 17:19:02 UTC) #7
kkania
The CQ bit was checked by kkania@chromium.org
6 years, 9 months ago (2014-03-03 17:22:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/116833004/20001
6 years, 9 months ago (2014-03-03 17:27:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/116833004/20001
6 years, 9 months ago (2014-03-03 17:36:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/116833004/20001
6 years, 9 months ago (2014-03-03 18:28:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/116833004/20001
6 years, 9 months ago (2014-03-03 19:54:56 UTC) #12
kkania
The CQ bit was unchecked by kkania@chromium.org
6 years, 9 months ago (2014-03-03 21:34:15 UTC) #13
kkania
The CQ bit was checked by kkania@chromium.org
6 years, 9 months ago (2014-03-03 21:35:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/116833004/20001
6 years, 9 months ago (2014-03-03 21:36:27 UTC) #15
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 21:38:37 UTC) #16
Message was sent while issue was closed. 
Change committed as 254569

Powered by Google App Engine
This is Rietveld 408576698