Support parameter passing for shadow-dom.js's createShadowRoot

Support parameter passing for shadow-dom.js's createShadowRoot

shadow-dom.js has a utility function 'createShadowRoot()'
for wrapping Element.createShadowRoot(), and this CL adds
support for passing its parameter as wrapper's 1st argument.
Only 'mode' property will be passed to Element.createShadowRoot()
and other properties are treated as attributes for shadow root
as before.

BUG=459136
TEST=fast/dom/shadow/create-shadow-root-with-parameter.html, not breaking other shadow-dom.js users

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196747

[kochi, 2015-06-09 04:13:27]

kochi@chromium.org changed reviewers:
+ hayato@chromium.org

[kochi, 2015-06-09 04:13:34]

PTAL

[hayato, 2015-06-09 04:34:38]

lgtm

https://codereview.chromium.org/1168323002/diff/1/LayoutTests/fast/dom/shadow...
File LayoutTests/fast/dom/shadow/resources/shadow-dom.js (right):

https://codereview.chromium.org/1168323002/diff/1/LayoutTests/fast/dom/shadow...
LayoutTests/fast/dom/shadow/resources/shadow-dom.js:13: var obj =
{'isShadowRoot': true,
Nit:  I'd prefer returning obj as is here, e.g. return {,,,, 'parameter':
parameter}.

Then we'll judge whether child.parameter is empty or not, later, in L45.

e.g.
 if (isEmpty(child.parameter))
  shadowRoot = ...

[kochi, 2015-06-09 04:46:57]

Thanks for the review.

https://codereview.chromium.org/1168323002/diff/1/LayoutTests/fast/dom/shadow...
File LayoutTests/fast/dom/shadow/resources/shadow-dom.js (right):

https://codereview.chromium.org/1168323002/diff/1/LayoutTests/fast/dom/shadow...
LayoutTests/fast/dom/shadow/resources/shadow-dom.js:13: var obj =
{'isShadowRoot': true,
On 2015/06/09 04:34:38, hayato wrote:
> Nit:  I'd prefer returning obj as is here, e.g. return {,,,, 'parameter':
> parameter}.
> 
> Then we'll judge whether child.parameter is empty or not, later, in L45.
> 
> e.g.
>  if (isEmpty(child.parameter))
>   shadowRoot = ...
> 
>  

Done.

[kochi, 2015-06-09 04:47:16]

The CQ bit was checked by kochi@chromium.org

[kochi, 2015-06-09 04:47:16]

The patchset sent to the CQ was uploaded after l-g-t-m from hayato@chromium.org
Link to the patchset: https://codereview.chromium.org/1168323002/#ps20001
(title: "Fix for comment, and update test expectation.")

[commit-bot: I haz the power, 2015-06-09 04:47:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1168323002/20001

[commit-bot: I haz the power, 2015-06-09 07:26:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 07:26:18]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65791)

[kochi, 2015-06-09 07:29:02]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2015-06-09 07:29:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1168323002/20001

[commit-bot: I haz the power, 2015-06-09 08:53:50]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196747