Revert[2] SkDraw and all Blitters to use pixmap instead of bitmapi

src/core/SkDeviceLooper.h

Index: src/core/SkDeviceLooper.h
diff --git a/src/core/SkDeviceLooper.h b/src/core/SkDeviceLooper.h
index a218345ae8b6546bea963457ce69be9882275f70..dd346d7445594e7a26e3276929cbf365bc9bc13a 100644
--- a/src/core/SkDeviceLooper.h
+++ b/src/core/SkDeviceLooper.h
@@ -30,14 +30,13 @@
  */
 class SkDeviceLooper {
 public:
-    SkDeviceLooper(const SkBitmap& base, const SkRasterClip&,
-                   const SkIRect& bounds, bool aa);
+    SkDeviceLooper(const SkPixmap& base, const SkRasterClip&, const SkIRect& bounds, bool aa);
     ~SkDeviceLooper();
 
-    const SkBitmap& getBitmap() const {
+    const SkPixmap& getPixmap() const {
         SkASSERT(kDone_State != fState);
-        SkASSERT(fCurrBitmap);
-        return *fCurrBitmap;
+        SkASSERT(fCurrDst);
+        return *fCurrDst;
     }
 
     const SkRasterClip& getRC() const {
@@ -61,7 +60,7 @@ public:
     bool next();
 
 private:

[robertphillips, 2015/06/09 18:17:37]

Do you really want/need this to be a reference?

[reed1, 2015/06/09 18:34:10]

Hard to know the value/cost of the tradeoff (copying -vs- indirection). The old
version used refs for both bitmap and clip, so I kept that pattern.

-    const SkBitmap&     fBaseBitmap;
+    const SkPixmap&     fBaseDst;
     const SkRasterClip& fBaseRC;
 
     enum State {
@@ -71,10 +70,10 @@ private:
     };
 
     // storage for our tiled versions. Perhaps could use SkTLazy
-    SkBitmap            fSubsetBitmap;
+    SkPixmap            fSubsetDst;
     SkRasterClip        fSubsetRC;
 
-    const SkBitmap*     fCurrBitmap;
+    const SkPixmap*     fCurrDst;
     const SkRasterClip* fCurrRC;
     SkIRect             fClippedBounds;
     SkIPoint            fCurrOffset;