Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1168223003:
Move build flags to .gni file. (Closed)
|
Created:
5 years, 6 months ago by brettw Modified:
5 years, 5 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove build flags to .gni file.
Add comments to build config about target setup.
Committed: https://crrev.com/fd1c6721afa39afa7f9d8a36f3faa683061726e9
Cr-Commit-Position: refs/heads/master@{#338865}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Review comments #Patch Set 3 : #Patch Set 4 : #
Messages
Total messages: 26 (13 generated)
brettw@chromium.org changed reviewers: + dpranke@chromium.org
This is blocked by a nacl and ffmpeg roll, but is ready to be reviewed now.
lgtm w/ nits. https://codereview.chromium.org/1168223003/diff/1/build/config/BUILDCONFIG.gn File build/config/BUILDCONFIG.gn (right): https://codereview.chromium.org/1168223003/diff/1/build/config/BUILDCONFIG.gn... build/config/BUILDCONFIG.gn:12: # Users would typically only set the variables "target_os" and "target_cpu" in nit: I would omit "would", i.e. "Users typically ..." https://codereview.chromium.org/1168223003/diff/1/build/config/BUILDCONFIG.gn... build/config/BUILDCONFIG.gn:20: # run the same build file multiple times for the different requried nit: typo: "required"
The CQ bit was checked by brettw@chromium.org to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/1168223003/#ps20001 (title: "Review comments")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168223003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
The CQ bit was checked by brettw@chromium.org to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/1168223003/#ps40001 (title: " ")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168223003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
The CQ bit was checked by brettw@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/1168223003/#ps60001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168223003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168223003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168223003/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/fd1c6721afa39afa7f9d8a36f3faa683061726e9 Cr-Commit-Position: refs/heads/master@{#338865} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
