Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1168203004: Add material shadows to toolbar and drawer (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add material shadows to toolbar and drawer Also, I've fixed the mask color on the drawer. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/2df42fdeedac7703959c4451a9877679827c5c15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M sky/sdk/lib/framework/components2/drawer.dart View 3 chunks +12 lines, -10 lines 0 comments Download
M sky/sdk/lib/framework/components2/fixed_height_scrollable.dart View 1 chunk +9 lines, -4 lines 0 comments Download
M sky/sdk/lib/framework/components2/tool_bar.dart View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-09 18:28:47 UTC) #1
Hixie
lgtm
5 years, 6 months ago (2015-06-09 19:04:22 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-06-09 19:07:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2df42fdeedac7703959c4451a9877679827c5c15 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698