Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(86)

Issue 1168173002: WebPluginContainerImpl::isRectTopmost: Clip query rect to frame. (Closed)

Created:
4 years, 10 months ago by bbudge
Modified:
4 years, 10 months ago
Reviewers:
dcheng
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

WebPluginContainerImpl::isRectTopmost: Clip query rect to frame. Changes isRectTopmost implementation to first clip the query rect to the frame bounds. If this is empty, return false. BUG=474836 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196710

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
bbudge
I'm not sure about the semantics of isRectTopmost, but this seems to fix the problem.
4 years, 10 months ago (2015-06-08 20:24:33 UTC) #2
dcheng
Can you add me to the CC list on the bug? It's hard for me ...
4 years, 10 months ago (2015-06-08 20:54:59 UTC) #3
bbudge
On 2015/06/08 20:54:59, dcheng wrote: > Can you add me to the CC list on ...
4 years, 10 months ago (2015-06-08 20:56:53 UTC) #4
dcheng
lgtm
4 years, 10 months ago (2015-06-08 21:53:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168173002/1
4 years, 10 months ago (2015-06-08 23:38:16 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-08 23:41:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196710

Powered by Google App Engine
This is Rietveld 408576698