Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1168153004: Limit number of raster threads on Android. (Closed)

Created:
5 years, 6 months ago by vmiura
Modified:
5 years, 6 months ago
Reviewers:
reveman, no sievers
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Limit number of raster threads on Android. The current formula for number of raster threads is (num_cpus / 2), minus 1 if using asynchronous uploads. This will give: 1~2 threads on 4 core devices 2~3 threads on 6 core devices 3~4 threads on 8 core devices Android can report 6 to 8 cores for big.LITTLE devices, where we don't really want to utilize all the cores at once. This change limits the cores to 4 in the render threads calculation. R=sievers@chromium.org R=reveman@chromium.org BUG=493432 Committed: https://crrev.com/6bfd5d8926aa101b39b0d3548b5dfd6cfad8b734 Cr-Commit-Position: refs/heads/master@{#333599}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M content/browser/gpu/compositor_util.cc View 1 chunk +9 lines, -1 line 2 comments Download

Messages

Total messages: 9 (2 generated)
vmiura
ptal
5 years, 6 months ago (2015-06-09 02:00:55 UTC) #2
reveman
lgtm but maybe we should also update base::SysInfo to better accommodate these devices. e.g. add ...
5 years, 6 months ago (2015-06-09 02:17:07 UTC) #3
no sievers
lgtm https://codereview.chromium.org/1168153004/diff/20001/content/browser/gpu/compositor_util.cc File content/browser/gpu/compositor_util.cc (right): https://codereview.chromium.org/1168153004/diff/20001/content/browser/gpu/compositor_util.cc#newcode212 content/browser/gpu/compositor_util.cc:212: // it uses its own thread, so reduce ...
5 years, 6 months ago (2015-06-09 18:26:31 UTC) #4
reveman
https://codereview.chromium.org/1168153004/diff/20001/content/browser/gpu/compositor_util.cc File content/browser/gpu/compositor_util.cc (right): https://codereview.chromium.org/1168153004/diff/20001/content/browser/gpu/compositor_util.cc#newcode212 content/browser/gpu/compositor_util.cc:212: // it uses its own thread, so reduce the ...
5 years, 6 months ago (2015-06-09 19:28:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168153004/20001
5 years, 6 months ago (2015-06-09 22:06:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 6 months ago (2015-06-09 22:47:15 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 22:48:07 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bfd5d8926aa101b39b0d3548b5dfd6cfad8b734
Cr-Commit-Position: refs/heads/master@{#333599}

Powered by Google App Engine
This is Rietveld 408576698