Chromecast PSSH boxes must use data_size parameter.

Chromecast PSSH boxes must use data_size parameter.

R=halliwell@chromium.org,lcwu@chromium.org
BUG=498003
Committed: https://crrev.com/9fe59726454bff4d3171f791955f3b9af04b0bc8
Cr-Commit-Position: refs/heads/master@{#333547}

[gunsch, 2015-06-08 23:03:32]

gunsch@chromium.org changed reviewers:
+ vadimgo@chromium.org

[gunsch, 2015-06-08 23:03:40]

[+vadim]

[vadimgo, 2015-06-08 23:07:51]

lgtm

[halliwell, 2015-06-09 00:41:48]

On 2015/06/08 23:07:51, vadimgo wrote:
> lgtm

lgtm

[lcwu1, 2015-06-09 18:22:22]

https://codereview.chromium.org/1168153003/diff/1/chromecast/media/cdm/chrome...
File chromecast/media/cdm/chromecast_init_data.cc (right):

https://codereview.chromium.org/1168153003/diff/1/chromecast/media/cdm/chrome...
chromecast/media/cdm/chromecast_init_data.cc:113: RCHECK(data_size == box_size -
box_bytes_read);
Are we adding a new data_size field in the custom data? Why do we need this?

I am fine with that, but if so, we will need to communicate that with devrel and
tam teams.

[gunsch, 2015-06-09 18:54:13]

https://codereview.chromium.org/1168153003/diff/1/chromecast/media/cdm/chrome...
File chromecast/media/cdm/chromecast_init_data.cc (right):

https://codereview.chromium.org/1168153003/diff/1/chromecast/media/cdm/chrome...
chromecast/media/cdm/chromecast_init_data.cc:113: RCHECK(data_size == box_size -
box_bytes_read);
On 2015/06/09 18:22:22, lcwu1 wrote:
> Are we adding a new data_size field in the custom data? Why do we need this?
> 
> I am fine with that, but if so, we will need to communicate that with devrel
and
> tam teams. 

We are not, and even if we were this does not affect anything for content
partners.

1) The way we communicate CustomData to our plugin is an internal implementation
detail negotiated between MPL and cast_shell.

2) PSSH boxes *must* have a four-byte data_size field (per the CENC spec) at
this location, even though that duplicates information about the rest of the
box. So this was actually a bug in my first implementation---not realizing this
difference about PSSH boxes in particular as opposed to the UUID box we were
using previously.

[lcwu1, 2015-06-09 19:11:05]

lgtm

[gunsch, 2015-06-09 19:11:42]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2015-06-09 19:12:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1168153003/1

[commit-bot: I haz the power, 2015-06-09 19:17:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-09 19:19:46]

Patchset 1 (id:??) landed as
https://crrev.com/9fe59726454bff4d3171f791955f3b9af04b0bc8
Cr-Commit-Position: refs/heads/master@{#333547}