Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 1168103003: Oilpan: fix unit tests bugs unmasked by r196836. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, dshwang, blink-reviews-html_chromium.org, dglazkov+blink, Rik, Justin Novosad
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix unit tests bugs unmasked by r196836. R=haraken BUG=498604 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -14 lines) Patch
M Source/core/editing/FrameSelectionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/GranularityStrategyTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2DTest.cpp View 8 chunks +40 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look. Bots are red.
5 years, 6 months ago (2015-06-10 09:19:36 UTC) #2
haraken
LGTM
5 years, 6 months ago (2015-06-10 09:21:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168103003/1
5 years, 6 months ago (2015-06-10 09:47:04 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 09:51:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196851

Powered by Google App Engine
This is Rietveld 408576698