Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(46)

Issue 1168093003: Expand the clip rect for cull rect verification. (Closed)

Created:
4 years, 10 months ago by Stephen Chennney
Modified:
4 years, 10 months ago
CC:
blink-reviews, krit, pdr+graphicswatchlist_chromium.org, dshwang, jbroman, slimming-paint-reviews_chromium.org, danakj, Rik, f(malita), Justin Novosad, blink-reviews-paint_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expand the clip rect for cull rect verification. Discussion with Skia team revealed that skia expands the cull rect by one pixel (effectively) when rejection testing, so expand our verification by one pixel too. BUG=496260 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196766

Patch Set 1 #

Patch Set 2 : Fix build' #

Patch Set 3 : Clip rect modification only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M Source/platform/graphics/paint/DrawingRecorder.cpp View 1 2 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Stephen Chennney
This is the verification clip rect inflation that provides our current-best-option for verifying cull rects.
4 years, 10 months ago (2015-06-08 20:12:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168093003/40001
4 years, 10 months ago (2015-06-08 20:13:12 UTC) #4
fmalita_google_do_not_use
lgtm
4 years, 10 months ago (2015-06-08 20:19:38 UTC) #6
pdr.
On 2015/06/08 at 20:19:38, fmalita wrote: > lgtm LGTM2
4 years, 10 months ago (2015-06-08 20:35:02 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-08 21:17:23 UTC) #9
commit-bot: I haz the power
COMMIT=false detected. CQ is abandoning the patch.
4 years, 10 months ago (2015-06-09 13:30:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168093003/40001
4 years, 10 months ago (2015-06-09 13:54:55 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 13:58:09 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196766

Powered by Google App Engine
This is Rietveld 408576698