Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: src/compiler/js-typed-lowering.cc

Issue 1168093002: [strong] Implement strong mode restrictions on property access (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: slim down, improve tests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-factory.h" 5 #include "src/code-factory.h"
6 #include "src/compiler/access-builder.h" 6 #include "src/compiler/access-builder.h"
7 #include "src/compiler/js-graph.h" 7 #include "src/compiler/js-graph.h"
8 #include "src/compiler/js-typed-lowering.h" 8 #include "src/compiler/js-typed-lowering.h"
9 #include "src/compiler/linkage.h" 9 #include "src/compiler/linkage.h"
10 #include "src/compiler/node-matchers.h" 10 #include "src/compiler/node-matchers.h"
(...skipping 953 matching lines...) Expand 10 before | Expand all | Expand 10 after
964 check_false->AppendInput(graph()->zone(), if_false); 964 check_false->AppendInput(graph()->zone(), if_false);
965 check_true = if_true; 965 check_true = if_true;
966 } 966 }
967 967
968 // Fast case, because variable is not shadowed. Perform global object load. 968 // Fast case, because variable is not shadowed. Perform global object load.
969 Unique<Name> name = Unique<Name>::CreateUninitialized(access.name()); 969 Unique<Name> name = Unique<Name>::CreateUninitialized(access.name());
970 Node* global = graph()->NewNode( 970 Node* global = graph()->NewNode(
971 javascript()->LoadContext(0, Context::GLOBAL_OBJECT_INDEX, true), context, 971 javascript()->LoadContext(0, Context::GLOBAL_OBJECT_INDEX, true), context,
972 context, effect); 972 context, effect);
973 Node* fast = graph()->NewNode( 973 Node* fast = graph()->NewNode(
974 javascript()->LoadNamed(name, access.feedback(), access.mode()), global, 974 javascript()->LoadNamed(name, access.feedback(), SLOPPY, access.mode()),
975 vector, context, state1, state2, global, check_true); 975 global, vector, context, state1, state2, global, check_true);
976 976
977 // Slow case, because variable potentially shadowed. Perform dynamic lookup. 977 // Slow case, because variable potentially shadowed. Perform dynamic lookup.
978 uint32_t check_bitset = DynamicGlobalAccess::kFullCheckRequired; 978 uint32_t check_bitset = DynamicGlobalAccess::kFullCheckRequired;
979 Node* slow = graph()->NewNode( 979 Node* slow = graph()->NewNode(
980 javascript()->LoadDynamicGlobal(access.name(), check_bitset, 980 javascript()->LoadDynamicGlobal(access.name(), check_bitset,
981 access.feedback(), access.mode()), 981 access.feedback(), access.mode()),
982 vector, context, context, state1, state2, effect, check_false); 982 vector, context, context, state1, state2, effect, check_false);
983 983
984 // Replace value, effect and control uses accordingly. 984 // Replace value, effect and control uses accordingly.
985 Node* new_control = 985 Node* new_control =
(...skipping 632 matching lines...) Expand 10 before | Expand all | Expand 10 after
1618 } 1618 }
1619 1619
1620 1620
1621 MachineOperatorBuilder* JSTypedLowering::machine() const { 1621 MachineOperatorBuilder* JSTypedLowering::machine() const {
1622 return jsgraph()->machine(); 1622 return jsgraph()->machine();
1623 } 1623 }
1624 1624
1625 } // namespace compiler 1625 } // namespace compiler
1626 } // namespace internal 1626 } // namespace internal
1627 } // namespace v8 1627 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/js-operator.cc ('k') | src/full-codegen.h » ('j') | src/lookup.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698