[strong] Implement strong mode restrictions on property access

src/compiler/js-operator.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/js-operator.h"
 
 #include <limits>
 
 #include "src/base/lazy-instance.h"
 #include "src/compiler/opcodes.h"
@@ skipping 173 matching lines @@
 size_t hash_value(VectorSlotPair const& p) {
   // TODO(mvstanton): include the vector in the hash.
   base::hash<int> h;
   return h(p.slot().ToInt());
 }
 
 
 bool operator==(LoadNamedParameters const& lhs,
                 LoadNamedParameters const& rhs) {
   return lhs.name() == rhs.name() &&
          lhs.contextual_mode() == rhs.contextual_mode() &&

[Michael Starzinger, 2015/06/09 10:54:13]

This operator should be adapted as well.

[conradw, 2015/06/09 11:20:30]

Done.

          lhs.feedback() == rhs.feedback();
 }
 
 
 bool operator!=(LoadNamedParameters const& lhs,
                 LoadNamedParameters const& rhs) {
   return !(lhs == rhs);
 }
 
 
 size_t hash_value(LoadNamedParameters const& p) {
   return base::hash_combine(p.name(), p.contextual_mode(), p.feedback());

[Michael Starzinger, 2015/06/09 10:54:13]

This operator should be adapted as well.

[conradw, 2015/06/09 11:20:30]

Done.

 }
 
 
 std::ostream& operator<<(std::ostream& os, LoadNamedParameters const& p) {
   return os << Brief(*p.name().handle()) << ", " << p.contextual_mode();

[Michael Starzinger, 2015/06/09 10:54:13]

This operator should be adapted as well.

[conradw, 2015/06/09 11:20:30]

Done.

 }
 
 
 std::ostream& operator<<(std::ostream& os, LoadPropertyParameters const& p) {
   // Nothing special to print.

[Michael Starzinger, 2015/06/09 10:54:13]

This operator should be adapted as well.

[conradw, 2015/06/09 11:20:30]

Done.

   return os;
 }
 
 
 bool operator==(LoadPropertyParameters const& lhs,
                 LoadPropertyParameters const& rhs) {
   return lhs.feedback() == rhs.feedback();

[Michael Starzinger, 2015/06/09 10:54:13]

This operator should be adapted as well.

[conradw, 2015/06/09 11:20:30]

Done.

 }
 
 
 bool operator!=(LoadPropertyParameters const& lhs,
                 LoadPropertyParameters const& rhs) {
   return !(lhs == rhs);
 }
 
 
 const LoadPropertyParameters& LoadPropertyParametersOf(const Operator* op) {
   DCHECK_EQ(IrOpcode::kJSLoadProperty, op->opcode());
   return OpParameter<LoadPropertyParameters>(op);
 }
 
 
 size_t hash_value(LoadPropertyParameters const& p) {
   return hash_value(p.feedback());

[Michael Starzinger, 2015/06/09 10:54:13]

This operator should be adapted as well.

[conradw, 2015/06/09 11:20:30]

Done.

 }
 
 
 const LoadNamedParameters& LoadNamedParametersOf(const Operator* op) {
   DCHECK_EQ(IrOpcode::kJSLoadNamed, op->opcode());
   return OpParameter<LoadNamedParameters>(op);
 }
 
 
 bool operator==(StoreNamedParameters const& lhs,
@@ skipping 202 matching lines @@
   return new (zone()) Operator1<int>(                       // --
       IrOpcode::kJSCallConstruct, Operator::kNoProperties,  // opcode
       "JSCallConstruct",                                    // name
       arguments, 1, 1, 1, 1, 2,                             // counts
       arguments);                                           // parameter
 }
 
 
 const Operator* JSOperatorBuilder::LoadNamed(const Unique<Name>& name,
                                              const VectorSlotPair& feedback,
+                                             LanguageMode language_mode,
                                              ContextualMode contextual_mode) {
-  LoadNamedParameters parameters(name, feedback, contextual_mode);
+  LoadNamedParameters parameters(name, feedback, language_mode,
+                                 contextual_mode);
   return new (zone()) Operator1<LoadNamedParameters>(   // --
       IrOpcode::kJSLoadNamed, Operator::kNoProperties,  // opcode
       "JSLoadNamed",                                    // name
       1, 1, 1, 1, 1, 2,                                 // counts
       parameters);                                      // parameter
 }
 
 
-const Operator* JSOperatorBuilder::LoadProperty(
-    const VectorSlotPair& feedback) {
-  LoadPropertyParameters parameters(feedback);
+const Operator* JSOperatorBuilder::LoadProperty(const VectorSlotPair& feedback,
+                                                LanguageMode language_mode) {
+  LoadPropertyParameters parameters(feedback, language_mode);
   return new (zone()) Operator1<LoadPropertyParameters>(   // --
       IrOpcode::kJSLoadProperty, Operator::kNoProperties,  // opcode
       "JSLoadProperty",                                    // name
       2, 1, 1, 1, 1, 2,                                    // counts
       parameters);                                         // parameter
 }
 
 
 const Operator* JSOperatorBuilder::StoreNamed(LanguageMode language_mode,
                                               const Unique<Name>& name) {
@@ skipping 97 matching lines @@
   return new (zone()) Operator1<Unique<String>>(                 // --
       IrOpcode::kJSCreateCatchContext, Operator::kNoProperties,  // opcode
       "JSCreateCatchContext",                                    // name
       2, 1, 1, 1, 1, 2,                                          // counts
       name);                                                     // parameter
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8