Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1168073002: Revert "compositor-worker: Share a thread and an isolate for compositor workers." (Closed)

Created:
5 years, 6 months ago by szager1
Modified:
5 years, 6 months ago
Reviewers:
haraken, sadrul
CC:
blink-reviews, kinuko+worker_chromium.org, horo+watch_chromium.org, falken
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "compositor-worker: Share a thread and an isolate for compositor workers." This reverts commit 96568f24c0ff40a4bce29141ba8d59a394a24591. Example breakage: https://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/786 BUG=497634 TBR=sadrul@chromium.org CC=enne@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -513 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/WorkerThread.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 5 chunks +4 lines, -16 lines 0 comments Download
M Source/modules/InitModules.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
D Source/modules/compositorworker/CompositorWorkerManager.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/modules/compositorworker/CompositorWorkerManager.cpp View 1 chunk +0 lines, -150 lines 0 comments Download
D Source/modules/compositorworker/CompositorWorkerManagerTest.cpp View 1 chunk +0 lines, -232 lines 0 comments Download
M Source/modules/compositorworker/CompositorWorkerThread.h View 1 chunk +3 lines, -12 lines 0 comments Download
M Source/modules/compositorworker/CompositorWorkerThread.cpp View 2 chunks +3 lines, -32 lines 0 comments Download
M Source/modules/compositorworker/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/modules.gypi View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
szager1
5 years, 6 months ago (2015-06-08 08:28:28 UTC) #1
szager1
Committed patchset #1 (id:1) manually as 196657 (presubmit successful).
5 years, 6 months ago (2015-06-08 08:28:52 UTC) #2
haraken
5 years, 6 months ago (2015-06-08 08:41:00 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698