Issue 116803003: Add support for sysroots to GN's pkg-config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 116803003: Add support for sysroots to GN's pkg-config. (Closed)

Created:
7 years ago by brettw

Modified:
7 years ago

Reviewers:
piman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add support for sysroots to GN's pkg-config. This adds support similar to the GYP scripts for running pkg-config in the presence of sysroots. It also adds the linker flags by calling the existing horrible sysroot_ld_path.sh shell script that extracts stuff from the sysroot's configuration. With this change, official 32-bit linux builds work in the checked in 32-bit Debian sysroots. R=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241397

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+128 lines, -12 lines)			Patch
M	build/config/compiler/BUILD.gn	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	build/config/linux/pkg-config.py	View	5 chunks	+92 lines, -10 lines	0 comments	Download
M	build/config/linux/pkg_config.gni	View	2 chunks	+9 lines, -1 line	0 comments	Download
A	build/config/linux/sysroot_ld_path.py	View	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r241397 (presubmit successful).

Expand Messages | Collapse Messages