Issue 1168003002: Revert "Oilpan: fix build after r196583."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1168003002: Revert "Oilpan: fix build after r196583." (Closed)

Created:
4 years, 11 months ago by szager1

Modified:
4 years, 11 months ago

Reviewers:
haraken, yurys

CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, vivekg_samsung, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert "Oilpan: fix build after r196583." This reverts commit f35316229ae02ef512dee9c8aab9578c6ece2f13. Revert "DevTools: extract common inspector bindigns code into InspectorWrapper" This reverts commit 08a9fc8c50d1df0e5364356ba513b75de50f8475. BUG=497395 TBR=yurys@chromium.org CC=sigbjornf@opera.com NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196608

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+173 lines, -223 lines)			Patch
M	Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
D	Source/bindings/core/v8/inspector/InspectorWrapper.h	View	1 chunk	+0 lines, -102 lines	0 comments	Download
D	Source/bindings/core/v8/inspector/InspectorWrapper.cpp	View	1 chunk	+0 lines, -67 lines	0 comments	Download
M	Source/bindings/core/v8/inspector/V8InjectedScriptHost.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp	View	17 chunks	+85 lines, -28 lines	0 comments	Download
M	Source/bindings/core/v8/inspector/V8JavaScriptCallFrame.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/bindings/core/v8/inspector/V8JavaScriptCallFrame.cpp	View	3 chunks	+78 lines, -17 lines	0 comments	Download
M	Source/bindings/core/v8/v8.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

szager1

Committed patchset #1 (id:1) manually as 196608 (presubmit successful).

4 years, 11 months ago (2015-06-05 22:49:45 UTC) #2

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages