content/browser/renderer_host/media/DEPS - Issue 11680002: Implement screen capturer for MediaStream API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/renderer_host/media/DEPS

Issue 11680002: Implement screen capturer for MediaStream API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+media",	2 "+media",

	3 "+remoting/capturer",
	jam 2013/01/18 02:58:35 remoting is a chrome feature, i.e. it's not part o remoting is a chrome feature, i.e. it's not part of the web platform. why does content have to know about this? if there's common code in remoting directory that'll be used for webrtc (?), then it should be moved out of remoting.. Sergey Ulanov 2013/01/18 18:39:04 remoting/capturer is a separate library that imple Show quoted text On 2013/01/18 02:58:35, John Abd-El-Malek wrote: > remoting is a chrome feature, i.e. it's not part of the web platform. why does > content have to know about this? > > if there's common code in remoting directory that'll be used for webrtc (?), > then it should be moved out of remoting.. remoting/capturer is a separate library that implements screen capturing and it doesn't depend on any other parts of remoting code. Here I'm reusing it to implement screen capturer for webrtc, and so I think it's right to add this dependency in the content layer. Chrome itself doesn't depend on it directly or indirectly (we use use it on the host side, which is not in chrome). This library is used to implement chromoting host, so remoting/ seems like the right place for it, but I'm open to moving it somewhere else. What do you think would be a better place to put it? Somewhere in src/media? Would it be acceptable to do it later in a separate CL, so this one doesn't block other CLs I have that depend on this one?
3 ]	4 ]

OLD	NEW

« no previous file with comments | « no previous file | content/browser/renderer_host/media/screen_capturer.h » ('j') | no next file with comments »