Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1167903006: [Android] Speculative fix for DeviceUtils.EnableRoot issues. (Closed)

Created:
5 years, 6 months ago by jbudorick
Modified:
5 years, 6 months ago
Reviewers:
perezju
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Speculative fix for DeviceUtils.EnableRoot issues. Several bots occasionally fail commands immediately following calls to DeviceUtils.EnableRoot with "device not found" errors. I think this may be because adb wait-for-device can come back before the device is completely available. Switching to WaitUntilFullyBooted should ensure that the device has returned to a usable state (or is actually gone). BUG=493900 Committed: https://crrev.com/a95af720637c609f33ed76d89d658041f354a222 Cr-Commit-Position: refs/heads/master@{#333046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -9 lines) Patch
M build/android/pylib/device/device_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/device/device_utils_test.py View 4 chunks +35 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbudorick
5 years, 6 months ago (2015-06-05 03:27:27 UTC) #2
perezju
lgtm
5 years, 6 months ago (2015-06-05 08:28:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167903006/1
5 years, 6 months ago (2015-06-05 13:49:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 14:49:52 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 14:50:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a95af720637c609f33ed76d89d658041f354a222
Cr-Commit-Position: refs/heads/master@{#333046}

Powered by Google App Engine
This is Rietveld 408576698