Adding support checks for partially supported element types and updating tests.

sdk/lib/html/scripts/systemhtml.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the system to generate
 Dart:html APIs from the IDL database."""
 
 import emitter
 import os
@@ skipping 48 matching lines @@
     'Window.document',
     'Window.indexedDB',
     'Window.location',
     'Window.open',
     'Window.requestAnimationFrame',
     'Window.webkitCancelAnimationFrame',
     'Window.webkitRequestAnimationFrame',
     'WorkerContext.indexedDB',
     ])
 
+js_support_checks = {
+  'HTMLContentElement': "Element.isTagSupported('content')",
+  'HTMLDataListElement': "Element.isTagSupported('datalist')",
+  'HTMLDetailsElement': "Element.isTagSupported('details')",
+  'HTMLEmbedElement': "Element.isTagSupported('embed')",
+  # IE creates keygen as Block elements
+  'HTMLKeygenElement': "Element.isTagSupported('keygen') "
+      "&& (new Element.tag('keygen') is KeygenElement)",

[Emily Fortuna, 2012/12/27 23:06:49]

can we programmatically determine for which classes if we need to just check
"Element.isTagSupported('keygen')" versus "Element.isTagSupported('keygen')  &&
(new Element.tag('keygen') is KeygenElement)" ?  so we don't have to explicitly
write all of this out?

[blois, 2012/12/28 00:43:27]

isTagSupported checks if the browser treats it as an UnknownElement or not,
which is correct for the general case. But in some cases, the browser returns a
different element type than we ask for- this is what the additional check is.

If we had first-class generics then it'd be easier. As it is, the constructors
will generate exceptions in checked mode when the browser returns the wrong
element type, and that's what this table is based off of.

+  'HTMLMarqueeElement': "Element.isTagSupported('marquee')"
+      "&& (new Element.tag('marquee') is MarqueeElement)",
+  'HTMLMeterElement': "Element.isTagSupported('meter')",
+  'HTMLObjectElement': "Element.isTagSupported('object')",
+  'HTMLOutputElement': "Element.isTagSupported('output')",
+  'HTMLProgressElement': "Element.isTagSupported('progress')",
+  'HTMLTrackElement': "Element.isTagSupported('track')",
+}
 
 # Classes that offer only static methods, and therefore we should suppress
 # constructor creation.
 _static_classes = set(['Url'])
 
 # Information for generating element constructors.
 #
 # TODO(sra): maybe remove all the argument complexity and use cascades.
 #
 #   var c = new CanvasElement(width: 100, height: 70);
@@ skipping 304 matching lines @@
         CLASSNAME=self._interface_type_info.implementation_name(),
         EXTENDS=' extends %s' % base_class if base_class else '',
         IMPLEMENTS=implements_str,
         DOMNAME=self._interface.doc_js_name,
         NATIVESPEC=self._backend.NativeSpec())
     self._backend.StartInterface(self._implementation_members_emitter)
     self._backend.EmitHelpers(base_class)
     self._backend.AddConstructors(
         constructors, factory_provider, factory_constructor_name)
 
+    self._backend.EmitSupportCheck()
+
     events_class_name = self._event_generator.ProcessInterface(
         self._interface, interface_name,
         self._backend.CustomJSMembers(),
         implementation_emitter)
     if events_class_name:
       self._backend.EmitEventGetter(events_class_name)
 
     merged_interface = self._interface_type_info.merged_interface()
     if merged_interface:
       self._backend.AddMembers(self._database.GetInterface(merged_interface),
@@ skipping 59 matching lines @@
                      self._interface.doc_js_name)
     return (self._template_loader.TryLoad(template_file) or
             self._template_loader.Load('dart2js_impl.darttemplate'))
 
   def StartInterface(self, members_emitter):
     self._members_emitter = members_emitter
 
   def FinishInterface(self):
     pass
 
+  def HasSupportCheck(self):
+    return self._interface.doc_js_name in js_support_checks
+
+  def GetSupportCheck(self):
+    return js_support_checks.get(self._interface.doc_js_name)
+
+

[Emily Fortuna, 2012/12/27 23:06:49]

remove extra newline

[blois, 2012/12/28 00:43:27]

Done.

   def EmitStaticFactory(self, constructor_info):
     arguments = constructor_info.ParametersAsArgumentList()
     if arguments:
       arguments = ', ' + arguments
     self._members_emitter.Emit(
         "  static $INTERFACE_NAME _create($PARAMETERS_DECLARATION) => JS("
           "'$INTERFACE_NAME', "
           "'new $CONSTRUCTOR_NAME($ARGUMENTS_PATTERN)'$ARGUMENTS);\n",
         INTERFACE_NAME=self._interface_type_info.interface_name(),
         PARAMETERS_DECLARATION=constructor_info.ParametersDeclaration(
@@ skipping 520 matching lines @@
     for library_name in libraries:
       self._libraries[library_name] = DartLibrary(
           library_name, template_loader, library_type, output_dir)
 
   def AddFile(self, basename, library_name, path):
     self._libraries[library_name].AddFile(path)
 
   def Emit(self, emitter, auxiliary_dir):
     for lib in self._libraries.values():
       lib.Emit(emitter, auxiliary_dir)