Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(91)

Issue 1167893002: DevTools: do not show gray time for unaccounted time on threads other than main (Closed)

Created:
4 years, 11 months ago by caseq
Modified:
4 years, 11 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: do not show gray time for unaccounted time on threads other than main This reverts to old behavior of not including "other" time (i.e. time unaccounted by specific timeline events) from threads other than main into Frame statistics. This was a collateral damage from r196216, as we started to gather top-level tasks from all frames. While it might not technically be a bug, it currently produces lots of gray in Frames and looks rather confusing. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M LayoutTests/inspector/tracing/frame-model.html View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFrameModel.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
caseq
4 years, 11 months ago (2015-06-04 10:18:29 UTC) #2
caseq
4 years, 11 months ago (2015-06-04 10:18:47 UTC) #4
yurys
lgtm
4 years, 11 months ago (2015-06-04 11:07:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167893002/1
4 years, 11 months ago (2015-06-04 11:12:27 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 13:13:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196498

Powered by Google App Engine
This is Rietveld 408576698