Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 1167883002: [Mac] Include MacViews native app windows in regular builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@drag_event
Patch Set: Address comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/ui/cocoa/apps/chrome_app_window_client_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index 02e05b72887ef96b5c6b2cb66f6e8a77c5beb2af..387e004a1daf20b3cb99479053806545a7de3f57 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -198,7 +198,10 @@ source_set("ui") {
sources += rebase_path(gypi_values.chrome_browser_ui_views_sources,
".",
"//chrome")
- deps += [ "//components/constrained_window" ]
+ deps += [
+ "//components/constrained_window",
+ "//extensions/components/native_app_window",
+ ]
if (!is_chromeos) {
sources +=
rebase_path(gypi_values.chrome_browser_ui_views_non_chromeos_sources,
@@ -210,7 +213,6 @@ source_set("ui") {
rebase_path(gypi_values.chrome_browser_ui_views_non_mac_sources,
".",
"//chrome")
- deps += [ "//extensions/components/native_app_window" ]
if (is_chromeos) {
# TODO(GYP): crbug.com/481629. These files should probably not be
# a part of ui_views_non_mac_sources at all.
@@ -311,7 +313,6 @@ source_set("ui") {
rebase_path(gypi_values.chrome_browser_ui_views_non_mac_sources,
".",
"//chrome")
- deps += [ "//extensions/components/native_app_window" ]
} else {
sources += rebase_path(gypi_values.chrome_browser_ui_cocoa_sources,
".",
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/ui/cocoa/apps/chrome_app_window_client_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698