chrome/browser/ui/cocoa/apps/DEPS - Issue 1167883002: [Mac] Include MacViews native app windows in regular builds.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/apps/DEPS

Issue 1167883002: [Mac] Include MacViews native app windows in regular builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@drag_event

Patch Set: Sync and rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/cocoa/apps/chrome_app_window_client_cocoa.mm » ('j') | chrome/browser/ui/cocoa/apps/chrome_app_window_client_cocoa.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+chrome/browser/ui/views",
	tapted 2015/06/04 04:48:00 Hm - I'm looking for a generic solution to this. Hm - I'm looking for a generic solution to this. WDYT of https://codereview.chromium.org/1162023008 ? it has other implications (see below) jackhou1 2015/06/04 06:06:40 I agree it makes sense to be explict about which f Show quoted text On 2015/06/04 04:48:00, tapted wrote: > Hm - I'm looking for a generic solution to this. > > WDYT of https://codereview.chromium.org/1162023008 ? > > it has other implications (see below) I agree it makes sense to be explict about which files: - don't need views, - use views but are part of the cocoa browser, - are part of the views browser. I expect there'll be a lot of files in the middle category before we can switch to mac_views_browser=1.
	3 ]

OLD	NEW