Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1167863002: Remove unused locking functionality from base::SharedMemory. (Closed)

Created:
5 years, 6 months ago by erikchen
Modified:
5 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@shared_memory_remove_abtest
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused locking functionality from base::SharedMemory. The only existing consumers of the locking functionality were two unit tests for SharedMemory. The first unit test only tested the locking functionality across threads, so I removed the test. The second unit test was intended to test cross-process functionality of base::SharedMemory, and used the locking functionality as a synchronization method between processes. I rewrote the test to actually test Shared Memory functionality, as the original test only tested synchronization between processes, and would have succeeded even if Shared Memory didn't work. I replaced the synchronization with compare and swap operations. BUG=466437, 345734 Committed: https://crrev.com/893dadc6e82a64c8135b6f4852ee0960ea62e4a5 Cr-Commit-Position: refs/heads/master@{#335135}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 8

Patch Set 5 : Rebase against top of tree. #

Patch Set 6 : Comments from thakis. #

Patch Set 7 : Comments from thakis, round two. #

Patch Set 8 : Use a barrier FAA. #

Patch Set 9 : Rebase against top of tree. #

Patch Set 10 : Disable test on Android. #

Patch Set 11 : Remove constant from android translation unit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -212 lines) Patch
M base/memory/shared_memory.h View 1 2 3 4 2 chunks +2 lines, -41 lines 0 comments Download
M base/memory/shared_memory_nacl.cc View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M base/memory/shared_memory_posix.cc View 1 2 3 4 5 chunks +0 lines, -37 lines 0 comments Download
M base/memory/shared_memory_unittest.cc View 1 2 3 4 5 6 7 8 9 10 7 chunks +29 lines, -96 lines 0 comments Download
M base/memory/shared_memory_win.cc View 1 2 3 4 5 chunks +5 lines, -30 lines 0 comments Download

Messages

Total messages: 41 (13 generated)
erikchen
thakis: Please review.
5 years, 6 months ago (2015-06-03 23:45:37 UTC) #2
erikchen
On 2015/06/03 23:45:37, erikchen wrote: > thakis: Please review. ping?
5 years, 6 months ago (2015-06-06 01:21:48 UTC) #3
erikchen
On 2015/06/06 01:21:48, erikchen wrote: > On 2015/06/03 23:45:37, erikchen wrote: > > thakis: Please ...
5 years, 6 months ago (2015-06-09 00:15:21 UTC) #4
erikchen
danakj: Please review.
5 years, 6 months ago (2015-06-10 23:03:27 UTC) #6
Nico
https://codereview.chromium.org/1167863002/diff/60001/base/memory/shared_memory.h File base/memory/shared_memory.h (left): https://codereview.chromium.org/1167863002/diff/60001/base/memory/shared_memory.h#oldcode315 base/memory/shared_memory.h:315: ino_t inode_; didn't you delete this field yesterday? i ...
5 years, 6 months ago (2015-06-11 15:39:18 UTC) #7
erikchen
-danakj
5 years, 6 months ago (2015-06-11 17:12:46 UTC) #9
erikchen
thakis: PTAL https://codereview.chromium.org/1167863002/diff/60001/base/memory/shared_memory.h File base/memory/shared_memory.h (left): https://codereview.chromium.org/1167863002/diff/60001/base/memory/shared_memory.h#oldcode315 base/memory/shared_memory.h:315: ino_t inode_; On 2015/06/11 15:39:18, Nico wrote: ...
5 years, 6 months ago (2015-06-11 17:36:30 UTC) #10
Nico
https://codereview.chromium.org/1167863002/diff/60001/base/memory/shared_memory_unittest.cc File base/memory/shared_memory_unittest.cc (right): https://codereview.chromium.org/1167863002/diff/60001/base/memory/shared_memory_unittest.cc#newcode604 base/memory/shared_memory_unittest.cc:604: int old_value = base::subtle::NoBarrier_CompareAndSwap(ptr, j, j + 1); On ...
5 years, 6 months ago (2015-06-11 17:46:41 UTC) #11
erikchen
https://codereview.chromium.org/1167863002/diff/60001/base/memory/shared_memory_unittest.cc File base/memory/shared_memory_unittest.cc (right): https://codereview.chromium.org/1167863002/diff/60001/base/memory/shared_memory_unittest.cc#newcode604 base/memory/shared_memory_unittest.cc:604: int old_value = base::subtle::NoBarrier_CompareAndSwap(ptr, j, j + 1); On ...
5 years, 6 months ago (2015-06-11 17:55:18 UTC) #12
Nico
lgtm!
5 years, 6 months ago (2015-06-11 18:03:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167863002/120001
5 years, 6 months ago (2015-06-11 18:15:08 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/32819)
5 years, 6 months ago (2015-06-11 20:57:02 UTC) #17
erikchen
On 2015/06/11 20:57:02, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 6 months ago (2015-06-11 21:10:08 UTC) #18
Nico
On 2015/06/11 21:10:08, erikchen wrote: > On 2015/06/11 20:57:02, commit-bot: I haz the power wrote: ...
5 years, 6 months ago (2015-06-11 21:40:34 UTC) #19
erikchen
On 2015/06/11 21:40:34, Nico wrote: > On 2015/06/11 21:10:08, erikchen wrote: > > On 2015/06/11 ...
5 years, 6 months ago (2015-06-11 21:47:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167863002/140001
5 years, 6 months ago (2015-06-11 21:50:03 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/32972)
5 years, 6 months ago (2015-06-12 00:16:37 UTC) #25
erikchen
On 2015/06/12 00:16:37, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 6 months ago (2015-06-12 00:19:20 UTC) #26
erikchen
On 2015/06/12 00:19:20, erikchen wrote: > On 2015/06/12 00:16:37, commit-bot: I haz the power wrote: ...
5 years, 6 months ago (2015-06-12 00:24:42 UTC) #27
erikchen
On 2015/06/12 00:24:42, erikchen wrote: > On 2015/06/12 00:19:20, erikchen wrote: > > On 2015/06/12 ...
5 years, 6 months ago (2015-06-12 00:25:11 UTC) #28
erikchen
On 2015/06/12 00:25:11, erikchen wrote: > On 2015/06/12 00:24:42, erikchen wrote: > > On 2015/06/12 ...
5 years, 6 months ago (2015-06-18 02:24:07 UTC) #29
Nico
On 2015/06/18 02:24:07, erikchen wrote: > On 2015/06/12 00:25:11, erikchen wrote: > > On 2015/06/12 ...
5 years, 6 months ago (2015-06-18 02:29:38 UTC) #30
erikchen
On 2015/06/18 02:29:38, Nico wrote: > On 2015/06/18 02:24:07, erikchen wrote: > > On 2015/06/12 ...
5 years, 6 months ago (2015-06-18 18:53:51 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167863002/180001
5 years, 6 months ago (2015-06-18 18:54:47 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/88349)
5 years, 6 months ago (2015-06-18 19:55:49 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167863002/200001
5 years, 6 months ago (2015-06-18 20:01:04 UTC) #39
commit-bot: I haz the power
Committed patchset #11 (id:200001)
5 years, 6 months ago (2015-06-18 21:48:43 UTC) #40
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 21:49:33 UTC) #41
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/893dadc6e82a64c8135b6f4852ee0960ea62e4a5
Cr-Commit-Position: refs/heads/master@{#335135}

Powered by Google App Engine
This is Rietveld 408576698