Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 1167833002: Make fast/layers/layer-visibility-sublayer.html unflaky (Closed)

Created:
4 years, 11 months ago by Justin Novosad
Modified:
4 years, 11 months ago
Reviewers:
esprehn, enne (OOO)
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make fast/layers/layer-visibility-sublayer.html unflaky This change makes layer-visibility-sublayer.html into a proper async test instead of one that relies on setTimeout. We need to rebaseline because most of the baselines show the wrong side of the race condition. LOL. BUG=488185 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -19 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/layers/layer-visibility-sublayer.html View 1 chunk +26 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Justin Novosad
PTAL
4 years, 11 months ago (2015-06-03 18:07:25 UTC) #2
Justin Novosad
Slow gardening day... got bored...
4 years, 11 months ago (2015-06-03 18:08:18 UTC) #3
esprehn
lgtm! Yay less flake. :)
4 years, 11 months ago (2015-06-03 18:13:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167833002/1
4 years, 11 months ago (2015-06-03 18:15:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65092)
4 years, 11 months ago (2015-06-03 21:16:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167833002/1
4 years, 11 months ago (2015-06-04 02:27:04 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 02:31:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196444

Powered by Google App Engine
This is Rietveld 408576698