Source/core/html/forms/ColorInputType.cpp - Issue 1167793003: Escape all of invalid values in console messages for INPUT elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/ColorInputType.cpp

Issue 1167793003: Escape all of invalid values in console messages for INPUT elements. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/imported/web-platform-tests/html/semantics/forms/the-input-element/date-expected.txt ('k') | Source/core/html/forms/DateInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/forms/ColorInputType.cpp

diff --git a/Source/core/html/forms/ColorInputType.cpp b/Source/core/html/forms/ColorInputType.cpp

index eb6276d7c7df16e039d32b8aa9cd7135fd46f843..66a17364cc9711e4feb16ab38114349788037722 100644

--- a/Source/core/html/forms/ColorInputType.cpp

+++ b/Source/core/html/forms/ColorInputType.cpp

@@ -48,6 +48,7 @@

#include "core/layout/LayoutTheme.h"

#include "core/layout/LayoutView.h"

#include "core/page/ChromeClient.h"

+#include "platform/JSONValues.h"

#include "platform/RuntimeEnabledFeatures.h"

#include "platform/UserGestureIndicator.h"

#include "platform/graphics/Color.h"

@@ -190,7 +191,7 @@ void ColorInputType::warnIfValueIsInvalid(const String& value) const

{

if (!equalIgnoringCase(value, element().sanitizeValue(value))) {

element().document().addConsoleMessage(ConsoleMessage::create(RenderingMessageSource, WarningMessageLevel,

- String::format("The specified value '%s' does not conform to the required format. The format is '#rrggbb' where rr, gg, bb are two-digit hexadecimal numbers.", value.utf8().data())));

+ String::format("The specified value %s does not conform to the required format. The format is \"#rrggbb\" where rr, gg, bb are two-digit hexadecimal numbers.", JSONValue::quoteString(value).utf8().data())));

}