Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1167793003: Escape all of invalid values in console messages for INPUT elements. (Closed)

Created:
5 years, 6 months ago by tkent
Modified:
5 years, 6 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Escape all of invalid values in console messages for INPUT elements. Showing some specific characters is problematic. For example, we can't handle a patch contains raw \r in -expected.txt. BUG=397952 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196653

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -80 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/accessibility/color-well-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/ValidityState-patternMismatch-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/color/color-value-sanitization-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-disabled-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/date/date-format-warning-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/date/date-pseudo-classes-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/date/input-date-validation-message-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/email-format-warning-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/forms/email-idn-conversion-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/fieldset/fieldset-form-collection-radionode-list-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/form-collection-radio-node-list-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/input-valueasnumber-unsupported-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/time/time-pseudo-classes-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/spatial-navigation/snav-date-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-validate-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooLong-expected.txt View 1 chunk +11 lines, -11 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooShort-expected.txt View 1 chunk +11 lines, -11 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/the-input-element/date-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/ColorInputType.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/forms/DateInputType.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/forms/EmailInputType.cpp View 2 chunks +2 lines, -15 lines 0 comments Download
M Source/core/html/forms/TimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/JSONValues.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/JSONValues.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
tkent
Keishi, please review this. Now we print \r as is in the warning messages. It ...
5 years, 6 months ago (2015-06-08 04:54:21 UTC) #6
keishi
LGTM
5 years, 6 months ago (2015-06-08 06:51:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167793003/60001
5 years, 6 months ago (2015-06-08 06:54:06 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 07:35:18 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196653

Powered by Google App Engine
This is Rietveld 408576698