Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1167753004: Remove dummy WebSettings::setRegionBasedColumnsEnabled(). (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)
Modified:
5 years, 6 months ago
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remove dummy WebSettings::setRegionBasedColumnsEnabled(). It had to linger until the Chromium side had stopped calling it. BUG=350853 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M Source/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 6 months ago (2015-06-03 12:38:31 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-05 12:06:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167753004/1
5 years, 6 months ago (2015-06-05 12:10:52 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 13:10:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196571

Powered by Google App Engine
This is Rietveld 408576698