Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: google_apis/gcm/engine/instance_id_get_token_request_handler.cc

Issue 1167753002: Add more UMAs for Instance ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/engine/instance_id_get_token_request_handler.cc
diff --git a/google_apis/gcm/engine/instance_id_get_token_request_handler.cc b/google_apis/gcm/engine/instance_id_get_token_request_handler.cc
index ebf6279af0502682268c1c681125e51cb111cb3d..ad7922732c28f792f259dbf53ee811b6473faeaf 100644
--- a/google_apis/gcm/engine/instance_id_get_token_request_handler.cc
+++ b/google_apis/gcm/engine/instance_id_get_token_request_handler.cc
@@ -4,6 +4,7 @@
#include "google_apis/gcm/engine/instance_id_get_token_request_handler.h"
+#include "base/metrics/histogram.h"
#include "base/strings/string_number_conversions.h"
#include "google_apis/gcm/base/gcm_util.h"
#include "net/url_request/url_request_context_getter.h"
@@ -53,4 +54,20 @@ void InstanceIDGetTokenRequestHandler::BuildRequestBody(std::string* body){
BuildFormEncoding(kSubtypeKey, authorized_entity_, body);
}
+void InstanceIDGetTokenRequestHandler::ReportUMAs(
+ RegistrationRequest::Status status,
+ int retry_count,
+ base::TimeDelta complete_time) {
+ UMA_HISTOGRAM_ENUMERATION("InstanceID.GetTokenRequestStatus",
+ status,
+ RegistrationRequest::STATUS_COUNT);
+
+ // Other UMAs are only reported when the request succeeds.
+ if (status != RegistrationRequest::SUCCESS)
+ return;
+
+ UMA_HISTOGRAM_COUNTS("InstanceID.GetTokenRetryCount", retry_count);
+ UMA_HISTOGRAM_TIMES("InstanceID.GetTokenCompleteTime", complete_time);
Alexei Svitkine (slow) 2015/06/04 18:59:32 Nit: Suggest putting an extra delimiter in all of
jianli 2015/06/04 20:50:22 Done.
+}
+
} // namespace gcm

Powered by Google App Engine
This is Rietveld 408576698