Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1167753002: Add more UMAs for Instance ID (Closed)

Created:
5 years, 6 months ago by jianli
Modified:
5 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more UMAs for Instance ID BUG=477084 Committed: https://crrev.com/c15821554cb1f1e62fa8e6ba30e9942c17324402 Cr-Commit-Position: refs/heads/master@{#332937}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address feedback #

Total comments: 8

Patch Set 3 : Address more feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -30 lines) Patch
M google_apis/gcm/engine/gcm_registration_request_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/gcm_registration_request_handler.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 1 2 3 chunks +25 lines, -6 lines 0 comments Download
M google_apis/gcm/engine/gcm_unregistration_request_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/gcm_unregistration_request_handler.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/instance_id_delete_token_request_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/instance_id_delete_token_request_handler.cc View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/instance_id_get_token_request_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/instance_id_get_token_request_handler.cc View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/registration_request.h View 1 chunk +5 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/registration_request.cc View 3 chunks +11 lines, -13 lines 0 comments Download
M google_apis/gcm/engine/unregistration_request.h View 1 chunk +5 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/unregistration_request.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
jianli
5 years, 6 months ago (2015-06-02 19:04:03 UTC) #2
fgorski
LGTM https://codereview.chromium.org/1167753002/diff/1/google_apis/gcm/engine/gcm_store_impl.cc File google_apis/gcm/engine/gcm_store_impl.cc (right): https://codereview.chromium.org/1167753002/diff/1/google_apis/gcm/engine/gcm_store_impl.cc#newcode345 google_apis/gcm/engine/gcm_store_impl.cc:345: iter != result->registrations.end(); nit: indentatoin https://codereview.chromium.org/1167753002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml ...
5 years, 6 months ago (2015-06-03 23:12:07 UTC) #3
jianli
https://codereview.chromium.org/1167753002/diff/1/google_apis/gcm/engine/gcm_store_impl.cc File google_apis/gcm/engine/gcm_store_impl.cc (right): https://codereview.chromium.org/1167753002/diff/1/google_apis/gcm/engine/gcm_store_impl.cc#newcode345 google_apis/gcm/engine/gcm_store_impl.cc:345: iter != result->registrations.end(); On 2015/06/03 23:12:07, fgorski wrote: > ...
5 years, 6 months ago (2015-06-03 23:31:17 UTC) #4
Alexei Svitkine (slow)
https://codereview.chromium.org/1167753002/diff/10001/google_apis/gcm/engine/gcm_store_impl.cc File google_apis/gcm/engine/gcm_store_impl.cc (right): https://codereview.chromium.org/1167753002/diff/10001/google_apis/gcm/engine/gcm_store_impl.cc#newcode346 google_apis/gcm/engine/gcm_store_impl.cc:346: ++iter) { Nit: Use C++ for loop: for (const ...
5 years, 6 months ago (2015-06-04 18:59:33 UTC) #5
jianli
https://codereview.chromium.org/1167753002/diff/10001/google_apis/gcm/engine/gcm_store_impl.cc File google_apis/gcm/engine/gcm_store_impl.cc (right): https://codereview.chromium.org/1167753002/diff/10001/google_apis/gcm/engine/gcm_store_impl.cc#newcode346 google_apis/gcm/engine/gcm_store_impl.cc:346: ++iter) { On 2015/06/04 18:59:32, Alexei Svitkine wrote: > ...
5 years, 6 months ago (2015-06-04 20:50:22 UTC) #6
jianli
zea, could you please also take a look? thanks.
5 years, 6 months ago (2015-06-04 20:50:52 UTC) #8
Alexei Svitkine (slow)
lgtm
5 years, 6 months ago (2015-06-04 20:54:33 UTC) #9
Nicolas Zea
lgtm
5 years, 6 months ago (2015-06-04 20:59:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167753002/30001
5 years, 6 months ago (2015-06-04 22:12:33 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:30001)
5 years, 6 months ago (2015-06-04 22:28:22 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 22:30:04 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c15821554cb1f1e62fa8e6ba30e9942c17324402
Cr-Commit-Position: refs/heads/master@{#332937}

Powered by Google App Engine
This is Rietveld 408576698