Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: Tools/Scripts/webkitpy/w3c/test_importer.py

Issue 1167723002: W3C test_importer.py includes 'support' and exclude 'tools' directories (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: jsbell's comments reflected Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/w3c/test_importer.py
diff --git a/Tools/Scripts/webkitpy/w3c/test_importer.py b/Tools/Scripts/webkitpy/w3c/test_importer.py
index 481e2dc9b3354bdefe2fe7ada88da4f3756c5723..368a9acdb51218d6a06cd30bf02e5c6eebecb177 100644
--- a/Tools/Scripts/webkitpy/w3c/test_importer.py
+++ b/Tools/Scripts/webkitpy/w3c/test_importer.py
@@ -196,7 +196,14 @@ class TestImporter(object):
reftests = 0
jstests = 0
- DIRS_TO_SKIP = ('.git', '.hg', 'test-plan')
+ # Files in 'tools' are not for browser testing (e.g., a script for generating test files).
+ # http://testthewebforward.org/docs/test-format-guidelines.html#tools
+ DIRS_TO_SKIP = ('.git', '.hg', 'test-plan', 'tools')
+
+ # Need to copy all files in 'support', including HTML without meta data.
+ # http://testthewebforward.org/docs/test-format-guidelines.html#support-files
+ DIRS_TO_INCLUDE = ('resources', 'support')
+
if dirs:
for d in DIRS_TO_SKIP:
if d in dirs:
@@ -240,7 +247,7 @@ class TestImporter(object):
copy_list.append({'src': fullpath, 'dest': filename})
continue
- if root.endswith('resources'):
+ if os.path.basename(root) in DIRS_TO_INCLUDE:
copy_list.append({'src': fullpath, 'dest': filename})
continue
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698