W3C test_importer.py includes 'support' and exclude 'tools' directories

W3C test_importer.py includes 'support' and exclude 'tools' directories

The test_importer.py does not copy HTML files without proper meta data. This
eliminates HTML files to load into IFRAME for instances today. The test format
guidelines defines that 'support' directory contains files to run tests,
so we should copy all files in this directory regardless of file types.
http://testthewebforward.org/docs/test-format-guidelines.html#support-files

This change fixes 4 CSS Writing Modes tests.

Also the guideline defines that 'tools' directory contains files not for a
browser (e.g., a script for generating test files). This directory can be
excluded.
http://testthewebforward.org/docs/test-format-guidelines.html#tools

This change eliminates the following file from the current file set:
  web-platform-tests/subresource-integrity/tools/generate_javascript.py
and more large files (~300k) are coming to the CSS WG test repositry.

BUG=492664
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196379

[kojii, 2015-06-02 19:01:51]

kojii@chromium.org changed reviewers:
+ dpranke@chromium.org, joelo@chromium.org, jsbell@chromium.org

[kojii, 2015-06-02 19:01:52]

PTAL.

[jsbell, 2015-06-02 19:12:00]

lgtm with a suggestion

https://codereview.chromium.org/1167723002/diff/1/Tools/Scripts/webkitpy/w3c/...
File Tools/Scripts/webkitpy/w3c/test_importer.py (right):

https://codereview.chromium.org/1167723002/diff/1/Tools/Scripts/webkitpy/w3c/...
Tools/Scripts/webkitpy/w3c/test_importer.py:247: if root.endswith('resources')
or root.endswith('support'):
How about:

if os.path.basename(root) in ('resources', 'support'):

... since the docs indicate we may want to add more e.g. /common/ and /media/ at
some point.

And maybe promote this to DIRS_TO_INCLUDE and define up with DIRS_TO_SKIP?

[Dirk Pranke, 2015-06-02 19:16:57]

lgtm. jsbell's comments make sense.

It's not real clear to me what the difference between 'resources' and 'support'
is, given what the w3c docs say. Might be worth asking them at some point.

[kojii, 2015-06-02 19:46:33]

Thank you both for the prompt review, I'll update according to the suggestions
and re-upload.

On 2015/06/02 19:16:57, Dirk Pranke wrote:
> lgtm. jsbell's comments make sense.
> 
> It's not real clear to me what the difference between 'resources' and
'support'
> is, given what the w3c docs say. Might be worth asking them at some point.

AFAIK, "resources" are what web-platform-tests invented and recently it's also
used in CSS WG thanks to TTWF's efforts to unify the guidelines among the two
test repos.

"support" is what CSS WG has been traditionally using since CSS 2. In CSS WG
test repo, 143 "support" directory while 4 "resources" directory.

[Dirk Pranke, 2015-06-02 19:55:05]

thanks, the web-platform-tests vs. csswg distinction make sense.

[joelo, 2015-06-02 20:11:04]

lgtm. thanks koji!

[kojii, 2015-06-03 07:22:59]

The CQ bit was checked by kojii@chromium.org

[kojii, 2015-06-03 07:22:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, jsbell@chromium.org, joelo@chromium.org
Link to the patchset: https://codereview.chromium.org/1167723002/#ps20001
(title: "jsbell's comments reflected")

[commit-bot: I haz the power, 2015-06-03 07:23:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1167723002/20001

[commit-bot: I haz the power, 2015-06-03 07:35:49]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196379