Move test runner to a component

components/test_runner/common/test_preferences.h

 // Copyright 2014 The Chromium Authors. All rights reserved.

[jam, 2015/06/02 18:02:59]

Searching cs
https://code.google.com/p/chromium/codesearch#search/&q=%22/shell/common/test...

i dont' see this being included in directories other than
content/shell/renderer/.

so can we fold components/test_runner/common and components/test_runner/renderer
into one directory (i.e. just move all this code into components/test_runner)? i
ask because having a renderer/common split into a componentized module that's
used by mandoline doesn't make as much sense because there's no "renderer"
process there.

[jochen (gone - plz use gerrit), 2015/06/02 18:36:27]

good point - IIRC we used to IPC that structure around, but obviously that's no
longer the case.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CONTENT_SHELL_COMMON_TEST_RUNNER_TEST_PREFERENCES_H_
-#define CONTENT_SHELL_COMMON_TEST_RUNNER_TEST_PREFERENCES_H_
+#ifndef COMPONENTS_TEST_RUNNER_COMMON_TEST_PREFERENCES_H_
+#define COMPONENTS_TEST_RUNNER_COMMON_TEST_PREFERENCES_H_
 
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/platform/WebURL.h"
 #include "third_party/WebKit/public/web/WebSettings.h"
 
 namespace blink {
 class WebView;
 }
 
 namespace content {

[jam, 2015/06/02 18:02:59]

are you planning on updating the namespace to test_runner in all these files in
a followup?

[jochen (gone - plz use gerrit), 2015/06/02 18:36:27]

yes

(and add export macros)

 
 struct TestPreferences {
     int default_font_size;
     int minimum_font_size;
     bool dom_paste_allowed;
     bool xss_auditor_enabled;
     bool allow_display_of_insecure_content;
     bool allow_file_access_from_file_urls;
     bool allow_running_of_insecure_content;
     bool author_and_user_styles_enabled;
@@ skipping 20 matching lines @@
     bool disable_reading_from_canvas;
     bool strict_mixed_content_checking;
     bool strict_powerful_feature_restrictions;
 
     TestPreferences();
     void Reset();
 };
 
 }
 
-#endif  // CONTENT_SHELL_COMMON_TEST_RUNNER_TEST_PREFERENCES_H_
+#endif  // COMPONENTS_TEST_RUNNER_COMMON_TEST_PREFERENCES_H_