Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: content/browser/frame_host/navigator_impl.h

Issue 1167693007: PlzNavigate: renderer-initiated navigations create a pending NavigationEntry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_
7 7
8 #include "base/containers/scoped_ptr_hash_map.h" 8 #include "base/containers/scoped_ptr_hash_map.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 118
119 // PlzNavigate: sends the NavigationRequest for |frame_tree_node| to the 119 // PlzNavigate: sends the NavigationRequest for |frame_tree_node| to the
120 // network stack so that it can start. 120 // network stack so that it can start.
121 void BeginNavigation(FrameTreeNode* frame_tree_node); 121 void BeginNavigation(FrameTreeNode* frame_tree_node);
122 122
123 void RecordNavigationMetrics( 123 void RecordNavigationMetrics(
124 const LoadCommittedDetails& details, 124 const LoadCommittedDetails& details,
125 const FrameHostMsg_DidCommitProvisionalLoad_Params& params, 125 const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
126 SiteInstance* site_instance); 126 SiteInstance* site_instance);
127 127
128 // Called when a navigation started in a main frame, to update the pending
Charlie Reis 2015/06/02 17:36:18 nit: has started
clamy 2015/06/03 09:11:10 Done.
129 // NavigationEntry if the controller does not currently have a
130 // browser-initiated one.
131 void MainFrameNavigationStarted(const GURL& url,
Charlie Reis 2015/06/02 17:36:18 DidStartMainFrameNavigation
clamy 2015/06/03 09:11:10 Done.
132 SiteInstanceImpl* site_instance);
133
128 // The NavigationController that will keep track of session history for all 134 // The NavigationController that will keep track of session history for all
129 // RenderFrameHost objects using this NavigatorImpl. 135 // RenderFrameHost objects using this NavigatorImpl.
130 // TODO(nasko): Move ownership of the NavigationController from 136 // TODO(nasko): Move ownership of the NavigationController from
131 // WebContentsImpl to this class. 137 // WebContentsImpl to this class.
132 NavigationControllerImpl* controller_; 138 NavigationControllerImpl* controller_;
133 139
134 // Used to notify the object embedding this Navigator about navigation 140 // Used to notify the object embedding this Navigator about navigation
135 // events. Can be NULL in tests. 141 // events. Can be NULL in tests.
136 NavigatorDelegate* delegate_; 142 NavigatorDelegate* delegate_;
137 143
138 scoped_ptr<NavigatorImpl::NavigationMetricsData> navigation_data_; 144 scoped_ptr<NavigatorImpl::NavigationMetricsData> navigation_data_;
139 145
140 DISALLOW_COPY_AND_ASSIGN(NavigatorImpl); 146 DISALLOW_COPY_AND_ASSIGN(NavigatorImpl);
141 }; 147 };
142 148
143 } // namespace content 149 } // namespace content
144 150
145 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_ 151 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/navigator_impl.cc » ('j') | content/browser/frame_host/navigator_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698