Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(47)

Issue 1167693004: Make SpaceSplitString::set() faster (Closed)

Created:
4 years, 11 months ago by Mikhail
Modified:
4 years, 11 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make SpaceSplitString::set() faster The SpaceSplitString in general and SpaceSplitString::set() in particular are used very intensively in the blink DOM handling code. This patch obviates an unneeded AtomicString re-creation within SpaceSplitString::set() method, as a result the median time value in the 'modify-element-classname.html' perf test decreased approximately by 2%-2.5%, VTune Amplifier shows the following delta of the total CPU time for the whole test execution: 3.610s - 3.550s = 0.060s (Linux desktop x64). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M Source/core/dom/SpaceSplitString.cpp View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mikhail
PTAL
4 years, 11 months ago (2015-06-02 13:43:21 UTC) #2
Mike West
Wonderful! LGTM.
4 years, 11 months ago (2015-06-02 16:24:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167693004/1
4 years, 11 months ago (2015-06-03 06:13:51 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2015-06-03 07:04:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196374

Powered by Google App Engine
This is Rietveld 408576698