build/android/pylib/base/base_setup.py - Issue 1167693002: remove stale test data on the device

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/base/base_setup.py

Issue 1167693002: remove stale test data on the device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove stale data from device Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright (c) 2014 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Base script for doing test setup."""	5 """Base script for doing test setup."""

6	6

7 import logging	7 import logging

8 import os	8 import os

9	9

10 from pylib import constants	10 from pylib import constants

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 # instead of md5sum. Perform a sanity check here.	52 # instead of md5sum. Perform a sanity check here.

53 i.VerifyHardlinks()	53 i.VerifyHardlinks()

54 i.PurgeExcluded(deps_exclusion_list)	54 i.PurgeExcluded(deps_exclusion_list)

55 i.MoveOutputDeps()	55 i.MoveOutputDeps()

56 return i	56 return i

57	57

58	58

59 def PushDataDeps(device, device_dir, test_options):	59 def PushDataDeps(device, device_dir, test_options):

60 valgrind_tools.PushFilesForTool(test_options.tool, device)	60 valgrind_tools.PushFilesForTool(test_options.tool, device)

61 if os.path.exists(constants.ISOLATE_DEPS_DIR):	61 if os.path.exists(constants.ISOLATE_DEPS_DIR):

62 device.PushChangedFiles([	62 if test_options.delete_stale_data:

63 (os.path.join(constants.ISOLATE_DEPS_DIR, p),	63 device.PushChangedFiles([(constants.ISOLATE_DEPS_DIR, device_dir)],

64 '%s/%s' % (device_dir, p))	64 delete_device_stale=True)

65 for p in os.listdir(constants.ISOLATE_DEPS_DIR)])	65 else:

	66 device.PushChangedFiles([

	67 (os.path.join(constants.ISOLATE_DEPS_DIR, p),

	68 '%s/%s' % (device_dir, p))

	69 for p in os.listdir(constants.ISOLATE_DEPS_DIR)])
	perezju 2015/06/10 09:24:22 why not replace the whole thing with just: device why not replace the whole thing with just: device.PushChangedFiles( [(constants.ISOLATE_DEPS_DIR, device_dir)], delete_device_stale=test_options.delete_stale_data) Menglin 2015/06/10 21:22:15 Done. Show quoted text On 2015/06/10 09:24:22, perezju wrote: > why not replace the whole thing with just: > > device.PushChangedFiles( > [(constants.ISOLATE_DEPS_DIR, device_dir)], > delete_device_stale=test_options.delete_stale_data) Done.
OLD	NEW

« no previous file with comments | « no previous file | build/android/pylib/device/device_utils.py » ('j') | build/android/pylib/device/device_utils.py » ('J')