Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1167653007: Cleanup: Rename ChromeClient::setWindowRect and setWindowRectInternal. (Closed)

Created:
4 years, 11 months ago by tkent
Modified:
4 years, 11 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Cleanup: Rename ChromeClient::setWindowRect and setWindowRectInternal. - Rename ChromeClient::setWindowRect to setWindowRectWithAdjustment - Rename ChromeClient::setWindowRectInternal to setWindowRect This CL has no behavior changes. BUG=495378 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M Source/core/frame/LocalDOMWindow.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/ChromeClient.h View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/page/ChromeClient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/CreateWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ChromeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
yosin@, please review this.
4 years, 11 months ago (2015-06-02 06:54:34 UTC) #2
yosin_UTC9
lgtm Thanks for improving readability.
4 years, 11 months ago (2015-06-02 08:09:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167653007/1
4 years, 11 months ago (2015-06-02 08:10:02 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 08:15:04 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196295

Powered by Google App Engine
This is Rietveld 408576698